Content-Length: 362948 | pFad | https://github.com/modxcms/revolution/pull/14999

EB Setup improvements by JoshuaLuckers · Pull Request #14999 · modxcms/revolution · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup improvements #14999

Merged
merged 8 commits into from
Aug 12, 2020
Merged

Setup improvements #14999

merged 8 commits into from
Aug 12, 2020

Conversation

JoshuaLuckers
Copy link
Contributor

@JoshuaLuckers JoshuaLuckers commented Feb 8, 2020 •
edited
Loading

What does it do?

Some technical improvements in the setup

Why is it needed?

To make the setup process more user friendly

Related issue(s)/PR(s)

Resolves issue #14742, #14974

@cla-bot cla-bot bot added the cla-signed CLA confirmed for contributors to this PR. label Feb 8, 2020
alroniks
alroniks reviewed Feb 10, 2020
View reviewed changes
setup/index.php Outdated Show resolved Hide resolved
setup/index.php Outdated Show resolved Hide resolved
@theboxer
Copy link
Member

theboxer commented Jul 1, 2020

@JoshuaLuckers any plans on finishing this one?

@JoshuaLuckers
Copy link
Contributor Author

Yes, but I'm not sure when. I hope to have some time in the upcoming weeks.

@JoshuaLuckers JoshuaLuckers marked this pull request as ready for review July 8, 2020 11:53
@JoshuaLuckers JoshuaLuckers requested a review from theboxer July 8, 2020 11:53
@JoshuaLuckers JoshuaLuckers added the pr/review-needed Pull request requires review and testing. label Jul 8, 2020
@JoshuaLuckers
Copy link
Contributor Author

JoshuaLuckers commented Jul 11, 2020 •
edited
Loading

I made some improvements in the way the requirements are validated. This is what it looks like when the requirements are not satisfied:

Screen Shot 2020-07-11 at 11 47 21

For this example I forced all requirements to always "fail" 🙈

@opengeek opengeek merged commit da62a58 into modxcms:3.x Aug 12, 2020
This was referenced Aug 13, 2020
Closed
Closed
@JoshuaLuckers JoshuaLuckers deleted the setup-improvements branch August 13, 2020 04:58
@opengeek opengeek added this to the v3.0.0-alpha3 milestone Dec 10, 2020
@theboxer theboxer mentioned this pull request Jan 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mishanthrop mishanthrop mishanthrop left review comments

@alroniks alroniks alroniks left review comments

@opengeek opengeek opengeek left review comments

@theboxer theboxer theboxer approved these changes

@Mark-H Mark-H Awaiting requested review from Mark-H Mark-H is a code owner

Assignees
No one assigned
Labels
cla-signed CLA confirmed for contributors to this PR. pr/review-needed Pull request requires review and testing.
Projects
None yet
Milestone
v3.0.0-alpha3
Development

Successfully merging this pull request may close these issues.
5 participants
@JoshuaLuckers @theboxer @opengeek @alroniks @mishanthrop








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/modxcms/revolution/pull/14999

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy