Content-Length: 487077 | pFad | https://github.com/muxinc/mux-player-swift/pull/64

2B test: Fix Sauce Labs Config by daytime-em · Pull Request #64 · muxinc/mux-player-swift · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix Sauce Labs Config #64

Merged
merged 40 commits into from
Jan 16, 2025
Merged

test: Fix Sauce Labs Config #64

merged 40 commits into from
Jan 16, 2025

Conversation

daytime-em
Copy link
Contributor

It turns out that getting XCUITest running with Sauce Labs is pretty simple. We were almost there, we just needed to fix the sauce config a little.

This PR also re-labels the Sauce Labs build step, since it was already doing saucectl run. The tests weren't running because .sauce/conf.yml specified a test app from a different SDK.

Successful runs:
https://app.saucelabs.com/tests/a3a9cf24b3e945299a1a3305e563e7ff
https://app.saucelabs.com/tests/1fbe7ca300c04cc5ab7d41a49675c3a3

Buildkite results:
https://buildkite.com/mux/mux-player-swift/builds/119

@daytime-em daytime-em requested a review from a team as a code owner January 14, 2025 23:46

echo "▸ Deploying app and Testing with Sauce"
echo "▸ Sauce Labs config: $(cat $PWD/.sauce/config.yml)"
saucectl run -c "$PWD/.sauce/config.yml"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this command already runs the tests (if the config points to a test suite that's in the runner)

although, We could add tags or something via CLI args to make the apps distinguishable in app storage

@daytime-em daytime-em marked this pull request as draft January 14, 2025 23:53
@daytime-em
Copy link
Contributor Author

daytime-em commented Jan 15, 2025

Un-drafing after cleanup (and fixing the mini)

@andrewjl-mux andrewjl-mux force-pushed the test/fix-saucelabs-conf branch from a0885e1 to dcaf3c4 Compare January 15, 2025 00:46
@daytime-em daytime-em marked this pull request as ready for review January 15, 2025 00:47
@andrewjl-mux andrewjl-mux force-pushed the test/fix-saucelabs-conf branch from fcebf00 to c8a9d7f Compare January 15, 2025 01:20
Copy link
Contributor

@andrewjl-mux andrewjl-mux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still want to run UI tests on the simulator in addition to running them on a SL device. Looks great otherwise!

@andrewjl-mux andrewjl-mux self-requested a review January 16, 2025 17:58
Copy link
Contributor

@andrewjl-mux andrewjl-mux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@daytime-em daytime-em merged commit 042c96a into main Jan 16, 2025
1 check passed
@daytime-em daytime-em deleted the test/fix-saucelabs-conf branch January 16, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/muxinc/mux-player-swift/pull/64

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy