-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Fix Sauce Labs Config #64
Conversation
|
||
echo "▸ Deploying app and Testing with Sauce" | ||
echo "▸ Sauce Labs config: $(cat $PWD/.sauce/config.yml)" | ||
saucectl run -c "$PWD/.sauce/config.yml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this command already runs the tests (if the config points to a test suite that's in the runner)
although, We could add tags or something via CLI args to make the apps distinguishable in app storage
Un-drafing after cleanup (and fixing the mini) |
…mux-player-swift into test/fix-saucelabs-conf
a0885e1
to
dcaf3c4
Compare
…r-swift into test/fix-saucelabs-conf
…r-swift into test/fix-saucelabs-conf
This reverts commit 6b6a851.
this already done by sauce labs
fcebf00
to
c8a9d7f
Compare
…r-swift into test/fix-saucelabs-conf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still want to run UI tests on the simulator in addition to running them on a SL device. Looks great otherwise!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
It turns out that getting XCUITest running with Sauce Labs is pretty simple. We were almost there, we just needed to fix the sauce config a little.
This PR also re-labels the Sauce Labs build step, since it was already doing
saucectl run
. The tests weren't running because.sauce/conf.yml
specified a test app from a different SDK.Successful runs:
https://app.saucelabs.com/tests/a3a9cf24b3e945299a1a3305e563e7ff
https://app.saucelabs.com/tests/1fbe7ca300c04cc5ab7d41a49675c3a3
Buildkite results:
https://buildkite.com/mux/mux-player-swift/builds/119