Content-Length: 457444 | pFad | https://github.com/namecheap/ilc/pull/246

80 feat: GuardManager & common PluginManager by oleh-momot · Pull Request #246 · namecheap/ilc · GitHub

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: GuardManager & common PluginManager #246

Merged

StyleT merged 17 commits into master from feature/route-guard-hook

Feb 5, 2021

Contributor

oleh-momot commented Jan 22, 2021

No description provided.

oleh-momot commented

View reviewed changes

ilc/server/pluginManager/PluginManager.js Outdated Show resolved Hide resolved

oleh-momot commented

View reviewed changes

ilc/client/GuardManager.js Outdated Show resolved Hide resolved

oleh-momot commented

View reviewed changes

ilc/build/webpack.js Outdated Show resolved Hide resolved

oleh-momot commented

View reviewed changes

ilc/client/ClientRouter.js Outdated Show resolved Hide resolved

oleh-momot commented

View reviewed changes

ilc/client/GuardManager.js Outdated Show resolved Hide resolved

oleh-momot commented

View reviewed changes

ilc/client/navigationEvents/setupEvents.js Outdated Show resolved Hide resolved

oleh-momot commented

View reviewed changes

ilc/package.json Outdated Show resolved Hide resolved

oleh-momot commented

View reviewed changes

ilc/client/navigationEvents/patchEvents.js Outdated Show resolved Hide resolved

StyleT suggested changes

View reviewed changes

ilc/build/webpack.js Outdated Show resolved Hide resolved

ilc/client/GuardManager.js Outdated Show resolved Hide resolved

ilc/client/GuardManager.js Outdated Show resolved Hide resolved

ilc/client/GuardManager.js Outdated Show resolved Hide resolved

ilc/server/app.js Outdated Show resolved Hide resolved

oleh-momot force-pushed the feature/route-guard-hook branch 3 times, most recently from 2de36a1 to c1992a7 Compare

January 22, 2021 18:02

oleh-momot commented

View reviewed changes

ilc/client/transitionHooksPlugin.js Outdated Show resolved Hide resolved

StyleT reviewed

View reviewed changes

ilc/client.js Show resolved Hide resolved

StyleT reviewed

View reviewed changes

ilc/client/GuardManager.js Outdated Show resolved Hide resolved

StyleT reviewed

View reviewed changes

ilc/client/navigationEvents/setupEvents.js Outdated Show resolved Hide resolved

oleh-momot commented

View reviewed changes

ilc/client.js Outdated Show resolved Hide resolved

oleh-momot changed the title ~~feat (WIP, POC): route guard hook~~ feat (WIP, POC): GuardManager & navigation hooks & PluginManager for both client and server usage

oleh-momot changed the title ~~feat (WIP, POC): GuardManager & navigation hooks & PluginManager for both client and server usage~~ feat (WIP, POC): GuardManager & PluginManager & transition hooks

oleh-momot force-pushed the feature/route-guard-hook branch 6 times, most recently from 664b7be to e580b26 Compare

January 29, 2021 09:17

oleh-momot changed the base branch from feature/route-guards to master

January 29, 2021 09:17

oleh-momot force-pushed the feature/route-guard-hook branch 4 times, most recently from 0535f99 to 934dbfa Compare

January 29, 2021 15:38

StyleT reviewed

View reviewed changes

ilc/client/GuardManager.js Outdated Show resolved Hide resolved

oleh-momot force-pushed the feature/route-guard-hook branch 4 times, most recently from dadb685 to d9b1b6d Compare

February 4, 2021 14:23

StyleT and others added 10 commits

February 4, 2021 16:25


          Merge branch 'master' into feature/route-guard-hook

56f6aef


          chore: speed up client tests

4b936ff


          chore: better code readability

a9cefb3


          chore: added "ILC" prefix to client side logs

28f4ddb


          chore: little code refactoring

74a3f3c


          chore: server tests refactoring

ef4f423


          chore: simplified GuardManager interface at server side

a497f37


          feat: better error handling

c405054


          fix: provide only meta field of a route to guard hooks

9fc8313


          feat: provide better logging

46abf5b

oleh-momot force-pushed the feature/route-guard-hook branch 2 times, most recently from 95755db to d48e73f Compare

February 4, 2021 14:32


          feat: provide an unlocalized URL to a guard hook and localize an redi…

69a7603

…rect to URL or when navigating from hook

oleh-momot force-pushed the feature/route-guard-hook branch from d48e73f to 69a7603 Compare

February 4, 2021 14:48


          fix: provide an URL as a string to navigation hooks

8b0dc9a

oleh-momot requested a review from StyleT

February 4, 2021 15:42


          fix: move expects from try statement block in setup events tests

b98b16c

StyleT reviewed

View reviewed changes

ilc/client/navigationEvents/setupEvents.js Outdated Show resolved Hide resolved


          fix: use a pathname, search, hash as an URL

93e9c35

oleh-momot requested a review from StyleT

February 5, 2021 09:09

StyleT approved these changes

View reviewed changes

nightnei approved these changes

View reviewed changes


          fix: save backward compatibility

920fca3

StyleT merged commit 237f963 into master

StyleT deleted the feature/route-guard-hook branch

February 5, 2021 14:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet