check_safe_pointers: warn if non-safe is assigned to safe variable.

Signed-off-by: NeilBrown <neil@brown.name>
neilbrown · Aug 1, 2016 · 4c03b37 · 4c03b37
1 parent cf1abbe
commit 4c03b37
Showing 1 changed file with 11 additions and 0 deletions.
diff --git a/check_safe_pointers.c b/check_safe_pointers.c
@@ -86,6 +86,17 @@ static void match_assign(struct expression *expr)
 		set_state_expr(my_id, expr->left, &safe);
 	else
 		set_state_expr(my_id, expr->left, &undefined);
+
+	if (is_safe(expr->left) && !is_safe_expr(expr->right)) {
+		char *namel, *namer;
+
+		namel = expr_to_str(expr->left);
+		namer = expr_to_str(expr->right);
+		sm_msg("'%s' can only take 'safe' pointers, not '%s'",
+		       namel, namer);
+		free_string(namel);
+		free_string(namer);
+	}
 }
 
 void check_safe_pointers(int id)