feat: add limited support for devEngines and .corepack.env
#634
+1,051
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduh95
changed the title
devEnginesdevEngines and .corepack.env
styfle
reviewed
Feb 7, 2025
Can you please explain these limitations? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the concept of
.corepack.envwhich would allow project maintainers to customize some parts of Corepack.We realistically cannot release it until Node.js 18.x is EOL(env parser is only available on Node.js 20.x LTS and later) in April, EDIT: actually it won't be as big of a deal as I thought, it falls back elegantly when run on a Node.js version without.envsupport.devEnginessupport in this PR is limited topackageManageronly, only onepackageManagercan be specified, theonFailfield is ignored.This PR also does not add support ofEDIT: this has been addresseddevEnginestocorepack useandcorepack up, which should be addressed before releasing.Fixes: #567
Fixes: #402
Fixes: #95
Should unblock fixing: #628