DOC: Fix ambiguity in polyfit description #28147
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charris
reviewed
May 10, 2025
| @@ -457,7 +457,7 @@ def polyfit(x, y, deg, rcond=None, full=False, w=None, cov=False): | |||
| A summary of the differences can be found in the | |||
| :doc:`transition guide </reference/routines.polynomials>`. | |||
|
|
|||
| Fit a polynomial ``p(x) = p[0] * x**deg + ... + p[deg]`` of degree `deg` | |||
| Fit a polynomial ``f(x) = p[0] * x**deg + ... + p[deg]`` of degree `deg` | |||
There was a problem hiding this comment.
I'd be inclined to just remove p(x) = , I don't think replacing p by f improves it.
There was a problem hiding this comment.
Alright got it, shall I close the Pr then as no changes are required?
There was a problem hiding this comment.
I think the suggestion is to remove p(x) so that it reads like this?
Suggested change
| Fit a polynomial ``f(x) = p[0] * x**deg + ... + p[deg]`` of degree `deg` | |
| Fit a polynomial ``p[0] * x**deg + ... + p[deg]`` of degree `deg` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28146
Clarified ambiguous usage of 'p' in polyfit documentation.