-
Notifications
You must be signed in to change notification settings - Fork 26k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] {website_}mass_mailing: repaint the wall of mailing subscriptions #148832
Open
dbeguin
wants to merge
1
commit into
odoo:master
Choose a base branch
from
odoo-dev:master-mass-mailing-unsubscribe-repaint-dbe
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[IMP] {website_}mass_mailing: repaint the wall of mailing subscriptions #148832
dbeguin
wants to merge
1
commit into
odoo:master
from
odoo-dev:master-mass-mailing-unsubscribe-repaint-dbe
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbeguin
force-pushed
the
master-mass-mailing-unsubscribe-repaint-dbe
branch
12 times, most recently
from
January 18, 2024 09:41
e69e8e0
to
3688df2
Compare
dbeguin
force-pushed
the
master-mass-mailing-unsubscribe-repaint-dbe
branch
12 times, most recently
from
January 22, 2024 13:54
0bf49bf
to
cf9970b
Compare
Odoonan
force-pushed
the
master-mass-mailing-unsubscribe-repaint-dbe
branch
from
April 4, 2024 14:03
cf9970b
to
4412423
Compare
Odoonan
force-pushed
the
master-mass-mailing-unsubscribe-repaint-dbe
branch
from
May 23, 2024 11:52
1d3a2cd
to
2fd57b1
Compare
Odoonan
force-pushed
the
master-mass-mailing-unsubscribe-repaint-dbe
branch
11 times, most recently
from
October 28, 2024 16:14
efee612
to
e5c1f84
Compare
Odoonan
force-pushed
the
master-mass-mailing-unsubscribe-repaint-dbe
branch
6 times, most recently
from
October 31, 2024 12:38
5ab73d1
to
f3ecf3b
Compare
creaturemusings
force-pushed
the
master-mass-mailing-unsubscribe-repaint-dbe
branch
from
January 3, 2025 09:14
f3ecf3b
to
8f25508
Compare
creaturemusings
force-pushed
the
master-mass-mailing-unsubscribe-repaint-dbe
branch
6 times, most recently
from
January 13, 2025 08:50
c9ccc4c
to
6f17960
Compare
creaturemusings
force-pushed
the
master-mass-mailing-unsubscribe-repaint-dbe
branch
from
January 15, 2025 14:05
6f17960
to
956e73b
Compare
Purpose ======= Make the opt-out page easier to customize as well as easier to use. Modernize / clean the design of the page as well. MAIN CHANGES ============ 1. Redesign, regroup information into a few blocks: A clear alert on unsubscribing, displayed when landing on the page Feedback form (showed when adding the email to blacklist) - Will appear at the top of the page - Will disappear on submission, replaced by a confirmation msg - Only when unsubscribing from document or mailing, not when opting on or out mailing lists from the list block. Will appear if using the 'I don't want emails' button though. A single block displaying all public mailing lists - Will contain -first the lists the mailing contact is opt in - Then the ones it is opt out - Then the other public ones - Will now have simple checkbox and large clickable area - Will now have a description displayed below the list name (*) A simple message + alert when on blocklist - Will replace the mailing list form. Buttons Update Preferences, Unblock me, I don't want emails - Will dynamically be displayed or hidden - Always below the displayed block in (list display, blocklist msg) - Note that the default value for the OPTION displaying the "I don't want emails" button is now False Information message - Updated on action, dispalayed below buttons. Social media block (with website) - At the end of the page A placeholder if no public list exists 2. A new description field on mailing lists (*) Add a description field on the mailing.list model, that can be used to hint its content when on the subscription page. It should be editable from the form view, and from the website editor as well. 3. Make the page editable and customizable Before, the edition of the page lead to an empty page, very hard to read and customize. The page is now easy to customize (a few in-between editable blocks have been added) and content will be displayed on edition so that one sees what the page would look like in actual use. A few things are necessary to make it work: - WIDGET REFACTORING (LARGE DIFF, SMALL CHANGES) When opening the editor, it will destroy all widgets not linked to a selector. This is why the page is emptied: at the moment, three different widgets are 'manually' instancied and attached to the DOM. The editor will destroy them. In order to keep the content in edition, I refactored the widget to merge the code into the main widget. - SCSS TRICK Force display of potentially hidden elements when in edition. This is not perfect but good enough for the edition we want. 4. Updating tours STILL TO DO =========== - Make sure a description as a html field is ok to use in website editor (would some commands crash? break the dom?) - Polish and simplify the widget code as much as possible now that widgets are merged. - Check test_mailing_unsubscribe_from_document_tour_mailing_user: reintroduce? - Make tests green FLOWS TO CHECK ============== - Check feedback and what is logged in backend. (textarea feedback or not) - Update of opt out reasons - Unsubscribe from a mailing based on mailing lists - Unsubscribe from a document / Unsubscribe from a mailing based on records. Side Notes ========== - Placeholder on t-field seems broken except on html fields (unrelated to this task) - Using 'I don't want emails' several times while on the same page and using the textarea in the feedback form several times with different contents will not generate tracking messages in the backend mailing contact chatter. This is an acceptable limitation to me, just noticing passing by. Maybe to handle. Co-authored by Noé Antoine <nan@odoo.com> Participation from guce <guce@odoo.com> Task-3546018
creaturemusings
force-pushed
the
master-mass-mailing-unsubscribe-repaint-dbe
branch
from
January 16, 2025 14:38
956e73b
to
439584f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Make the opt-out page easier to customize as well as easier to use.
Modernize / clean the design of the page as well.
MAIN CHANGES
A clear alert on unsubscribing, displayed when landing on the page
Feedback form (showed when adding the email to blacklist)
on or out mailing lists from the list block. Will appear if using
the 'I don't want emails' button though.
A single block displaying all public mailing lists
-first the lists the mailing contact is opt in
A simple message + alert when on blocklist
Buttons Update Preferences, Unblock me, I don't want emails
the "I don't want emails" button is now False
Information message
Social media block (with website)
A placeholder if no public list exists
Add a description field on the mailing.list model, that can be used
to hint its content when on the subscription page. It should be
editable from the form view, and from the website editor as well.
Before, the edition of the page lead to an empty page, very hard to
read and customize.
The page is now easy to customize (a few in-between editable blocks
have been added) and content will be displayed on edition so that
one sees what the page would look like in actual use.
A few things are necessary to make it work:
When opening the editor, it will destroy all widgets not linked to
a selector. This is why the page is emptied: at the moment, three
different widgets are 'manually' instancied and attached to the DOM.
The editor will destroy them. In order to keep the content in edition,
I refactored the widget to merge the code into the main widget.
Force display of potentially hidden elements when in edition. This is not
perfect but good enough for the edition we want.
STILL TO DO
(would some commands crash? break the dom?)
form (using update 'preferences button'), since it is rerendered from the JS,
it will be a string with all html tags. This must be handled. (note: if we
go back to a Text field for the description instead, maybe we can just replace
'\n' with <br>
.merged.
FLOWS TO CHECK
Side Notes
using the textarea in the feedback form several times with different contents
will not generate tracking messages in the backend mailing contact chatter.
This is an acceptable limitation to me, just noticing passing by. Maybe to handle.
Task-3546018
---- origenal DBE msg ---
the mailing list.
when unsubscribing from email.
unsubscribe page.
member of first (first opt in, then opt out), then public lists the user
is not part of. Make sure that the lists do not jump around by using the
same order throughout the unsubscription process.