[FIX] sale_timesheet: get profitability items from all linked projects #167999

lvsz · 2024-06-04T12:07:20Z

Versions

16.0+

Steps

Enable analytic accounting;
have a sales order with a timesheeted service product;
have two projects with different AALs;
link both projecs to the same SOL;
create timesheets in both projects;
open the profitability view of a project.

Issue

The profitability shows shows the total revenue of the SO, but only the cost of that specific project.

Cause

The _get_profitability_items override only checks the AAL associated with that project.

Solution

Call _get_profitability_items on all projects linked the the project's sales order.

opw-3631672

robodoo · 2024-06-04T12:08:13Z

.

nle-odoo

seems good to me but I'm not too knowledgeable about how these flow functionally work

nle-odoo · 2024-06-05T15:49:26Z

addons/sale_project/models/sale_order.py

@@ -128,12 +128,18 @@ class SaleOrderLine(models.Model):

    project_id = fields.Many2one(
        'project.project', 'Generated Project',
+        compute='_compute_project_id', store=True,


from this:

odoo/addons/sale_project/models/sale_order.py

Lines 29 to 32 in 0ae818c

@api.depends('order_line.product_id.service_tracking')

def _compute_visible_project(self):

""" Users should be able to select a project_id on the SO if at least one SO line has a product with its service tracking

configured as 'task_in_project' """

it seems like the user should be able to select a project, so the field should probably at least be readonly=False

They're able to select it on the SO, but this compute method only affect the order's lines, where project_id is assumed to be generated or provided by the SO rather than user-selected.

That field is only used to say the SOL generated that project, we don't really use it for the data displayed in the right side panel in project update, IMO. 🤔

And so that field is not used to say that SOL is linked to that project as you said in your commit message. 🙂

xavierbol

Thanks for the work, however, it does not seem you fix the bug explained in the video, the product used in the video does not create any project and task.

The steps to reproduce the issues described in your commit message are not the same than the ones showed in the video.

IMO, the bug is not in 15.0 and 16.0 but since 17.0.

xavierbol · 2024-06-14T08:24:19Z

addons/sale_project/models/sale_order.py

@@ -128,12 +128,18 @@ class SaleOrderLine(models.Model):

    project_id = fields.Many2one(
        'project.project', 'Generated Project',
+        compute='_compute_project_id', store=True,


That field is only used to say the SOL generated that project, we don't really use it for the data displayed in the right side panel in project update, IMO. 🤔

And so that field is not used to say that SOL is linked to that project as you said in your commit message. 🙂

lvsz · 2024-06-24T09:08:18Z

The steps to reproduce the issues described in your commit message are not the same than the ones showed in the video.

You're right, I think I forgot to enable analytic accounting, which is why I wasn't able to reproduce it as in the video.

IMO, the bug is not in 15.0 and 16.0 but since 17.0.

I'm not sure what you mean; as far as I can tell, the behavior in 17.0 is exactly the same as in 16.0.

Versions -------- - 16.0+ Steps ----- 1. Enable analytic accounting; 2. have a sales order with a timesheeted service product; 3. have two projects with different AALs; 4. link both projecs to the same SOL; 5. create timesheets in both projects; 6. open the profitability view of a project. Issue ----- The profitability shows shows the total revenue of the SO, but only the cost of that specific project. Cause ----- The `_get_profitability_items` override only checks the AAL associated with that project. Solution -------- Call `_get_profitability_items` on all projects linked the the project's sales order. opw-3631672

lvsz · 2025-01-07T15:06:48Z

Hi @xavierbol

Updated the PR in a way that it would fix the flow shown in the client video.

xavierbol · 2025-01-16T12:40:45Z

The _get_profitability_items override only checks the AAL associated with that project.

Why don't we want to just take into account the timesheets linked to the project? 🤯

To me, the issue explained on the ticket is because we take into account the whole revenue instead of just taking the revenues related to the work done in the project itself.

However, after investigating a bit, I don't think it is possible to fix that issue. 🧐

I will discuss about that with Alexandra (my product owner)

lvsz · 2025-01-16T16:32:55Z

However, after investigating a bit, I don't think it is possible to fix that issue. 🧐

Indeed, revenue is based on sale order lines, but one line can be linked to multiple projects/analytic accounts, so taking that approach would be way more complex, requiring some form of heuristic to divide the line's revenue between multiple timesheet entries.

xavierbol · 2025-01-17T08:10:09Z

Yep, that's why I think we should not cover that case since it is too complex. 🙁

C3POdoo added the OE the report is linked to a support ticket (opw-...) label Jun 4, 2024

lvsz force-pushed the 15.0-opw-3631672-update_sol_project_on_task_change-sile branch from e073f46 to 2c9d8a3 Compare June 5, 2024 11:49

nle-odoo approved these changes Jun 5, 2024

View reviewed changes

lvsz force-pushed the 15.0-opw-3631672-update_sol_project_on_task_change-sile branch 2 times, most recently from e3e3284 to 187b0a6 Compare June 6, 2024 07:27

lvsz changed the title ~~[FIX] sale_project: update sol project on task project change~~ sale_{project,timesheet}: update sol project based on task Jun 6, 2024

lvsz force-pushed the 15.0-opw-3631672-update_sol_project_on_task_change-sile branch from 187b0a6 to e84d2fc Compare June 6, 2024 07:29

lvsz changed the title ~~sale_{project,timesheet}: update sol project based on task~~ sale_{project,timesheet}: update SOL project based on task Jun 6, 2024

lvsz changed the title ~~sale_{project,timesheet}: update SOL project based on task~~ [FIX] sale_{project,timesheet}: update SOL project based on task Jun 6, 2024

lvsz force-pushed the 15.0-opw-3631672-update_sol_project_on_task_change-sile branch 3 times, most recently from 52abddb to a654dde Compare June 6, 2024 11:36

lvsz marked this pull request as ready for review June 6, 2024 20:41

C3POdoo requested a review from a team June 6, 2024 20:43

xavierbol reviewed Jun 14, 2024

View reviewed changes

lvsz marked this pull request as draft June 24, 2024 09:08

lvsz force-pushed the 15.0-opw-3631672-update_sol_project_on_task_change-sile branch from a654dde to 2b53425 Compare January 6, 2025 17:10

lvsz changed the base branch from 15.0 to 16.0 January 6, 2025 17:10

lvsz changed the title ~~[FIX] sale_{project,timesheet}: update SOL project based on task~~ [FIX] sale_timesheet: get profitability items from all linked projects Jan 6, 2025

lvsz force-pushed the 15.0-opw-3631672-update_sol_project_on_task_change-sile branch from 2b53425 to c8dce26 Compare January 7, 2025 11:51

lvsz marked this pull request as ready for review January 7, 2025 14:58

C3POdoo requested a review from a team January 7, 2025 14:59

lvsz requested a review from xavierbol January 16, 2025 11:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FIX] sale_timesheet: get profitability items from all linked projects #167999

[FIX] sale_timesheet: get profitability items from all linked projects #167999

lvsz commented Jun 4, 2024 •

edited

Loading

robodoo commented Jun 4, 2024 •

edited

Loading

nle-odoo left a comment

nle-odoo Jun 5, 2024

lvsz Jun 6, 2024 •

edited

Loading

xavierbol Jun 14, 2024

xavierbol left a comment

xavierbol Jun 14, 2024

lvsz commented Jun 24, 2024

lvsz commented Jan 7, 2025

xavierbol commented Jan 16, 2025

lvsz commented Jan 16, 2025

xavierbol commented Jan 17, 2025

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier! Saves Data!

	@api.depends('order_line.product_id.service_tracking')
	def _compute_visible_project(self):
	""" Users should be able to select a project_id on the SO if at least one SO line has a product with its service tracking
	configured as 'task_in_project' """

[FIX] sale_timesheet: get profitability items from all linked projects #167999

Are you sure you want to change the base?

[FIX] sale_timesheet: get profitability items from all linked projects #167999

Conversation

lvsz commented Jun 4, 2024 • edited Loading

Versions

Steps

Issue

Cause

Solution

robodoo commented Jun 4, 2024 • edited Loading

nle-odoo left a comment

Choose a reason for hiding this comment

nle-odoo Jun 5, 2024

Choose a reason for hiding this comment

lvsz Jun 6, 2024 • edited Loading

Choose a reason for hiding this comment

xavierbol Jun 14, 2024

Choose a reason for hiding this comment

xavierbol left a comment

Choose a reason for hiding this comment

xavierbol Jun 14, 2024

Choose a reason for hiding this comment

lvsz commented Jun 24, 2024

lvsz commented Jan 7, 2025

xavierbol commented Jan 16, 2025

lvsz commented Jan 16, 2025

xavierbol commented Jan 17, 2025

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier! Saves Data!

lvsz commented Jun 4, 2024 •

edited

Loading

robodoo commented Jun 4, 2024 •

edited

Loading

lvsz Jun 6, 2024 •

edited

Loading