Content-Length: 240301 | pFad | https://github.com/odoo/odoo/pull/193191

D7 [FIX] mail: refine emoji reactions for comments by ibo-odoo · Pull Request #193191 · odoo/odoo · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] mail: refine emoji reactions for comments #193191

Draft
wants to merge 1 commit into
base: 18.0
Choose a base branch
from

Conversation

ibo-odoo
Copy link
Contributor

Before this PR:

  • A non-logged-in user attempts to react with emojis on a comment, resulting in a traceback.
  • The reaction is not positioned directly below the comment, as other users add comments, it keeps moving further down.

After this PR:

  • The buttons for adding emoji reactions to comments will be hidden for non-logged-in users.
  • The reaction will be positioned directly below the comment for a more streamlined UI experience.

Task-4452408

@robodoo
Copy link
Contributor

robodoo commented Jan 10, 2025

Pull request status dashboard

@C3POdoo C3POdoo added the RD research & development, internal work label Jan 10, 2025
@ibo-odoo ibo-odoo force-pushed the 18.0-website-slides-comment-reaction-fix-ibo branch from f518e4a to 564d489 Compare January 13, 2025 10:12
Before this commit:
- A non-logged-in user attempts to react with emojis on a comment, resulting in a
traceback.
- The reaction is not positioned directly below the comment, and as other users
add comments, it keeps moving further down.

After this commit:
- The buttons for adding emoji reactions to comments will be hidden for
non-logged-in users.
- The reaction will be positioned directly below the comment for a more streamlined
UI experience.

Task-4452408

[FIX] mail: part2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/odoo/odoo/pull/193191

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy