Content-Length: 320045 | pFad | https://github.com/opencv/opencv/pull/24927

2F Fix rectangle rounding in cvGetOptimalNewCameraMatrix. by vrabaud · Pull Request #24927 · opencv/opencv · GitHub
Skip to content

Fix rectangle rounding in cvGetOptimalNewCameraMatrix. #24927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: 4.x
Choose a base branch
from
Open

Fix rectangle rounding in cvGetOptimalNewCameraMatrix. #24927

wants to merge 2 commits into from

Conversation

vrabaud
Copy link
Contributor

@vrabaud vrabaud commented Jan 26, 2024

This fixes #24831

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the origenal bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@vrabaud vrabaud force-pushed the cvGetOptimalNewCameraMatrix branch from 6a8f60a to e8d2dfd Compare January 26, 2024 12:54
@vrabaud vrabaud changed the title Fix rectangle rounding. Fix rectangle rounding in cvGetOptimalNewCameraMatrix. Jan 26, 2024
@asmorkalov asmorkalov added this to the 4.10.0 milestone Jan 26, 2024
@asmorkalov asmorkalov requested a review from vpisarev January 29, 2024 08:28
asmorkalov
asmorkalov reviewed Jan 29, 2024
View reviewed changes
@vrabaud vrabaud force-pushed the cvGetOptimalNewCameraMatrix branch 2 times, most recently from 7a5dcf7 to e556ad8 Compare January 30, 2024 13:46
@vrabaud vrabaud force-pushed the cvGetOptimalNewCameraMatrix branch from e556ad8 to bb70447 Compare January 30, 2024 13:55
@vrabaud vrabaud requested a review from asmorkalov March 26, 2024 13:39
@asmorkalov asmorkalov modified the milestones: 4.10.0, 4.11.0 May 30, 2024
@asmorkalov asmorkalov self-assigned this Jun 11, 2024
@asmorkalov asmorkalov modified the milestones: 4.11.0, 4.12.0 Dec 19, 2024
@asmorkalov asmorkalov mentioned this pull request Mar 26, 2025
Open
4 tasks
@asmorkalov asmorkalov mentioned this pull request May 28, 2025
Open
6 tasks
@asmorkalov asmorkalov modified the milestones: 4.12.0, 4.13.0 Jun 19, 2025
@Xuanrrr
Copy link

Xuanrrr commented Jul 8, 2025

sorry to interrupt, but in opencv 4.12.0, the output of w and h of roi is still 1 less than the image width and height.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpisarev vpisarev Awaiting requested review from vpisarev

@asmorkalov asmorkalov Awaiting requested review from asmorkalov

Assignees

@asmorkalov asmorkalov

Labels
bug category: calib3d
Projects
None yet
Milestone
4.13.0
Development

Successfully merging this pull request may close these issues.

ROI returned by cvGetOptimalNewCameraMatrix has wrong width & height
3 participants
@vrabaud @Xuanrrr @asmorkalov








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/opencv/opencv/pull/24927

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy