Add canny, scharr and sobel for riscv-rvv hal. #27378
Open
+4,518
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR triggers oom killer on Muse Pi v30 board: The issue is stable. |
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Thanks a lot for the fix. There is still failed test on CI: the function under test heavily use Sobel filter. |
fengyuentau
reviewed
Jun 18, 2025
There was a problem hiding this comment.
Got some build warnings from the toolchain:
/home/tao/workspace/fytao/k1/worktree/spacemit-imgproc-canny_scharr_sobel/opencv/hal/riscv-rvv/src/imgproc/sobel.cpp: In function 'int cv::rvv_hal::imgproc::sobel(const uint8_t*, size_t, uint8_t*, size_t, int, int, int, int, int, int, int, int, int, int, int, int, double, double, int)':
/home/tao/workspace/fytao/k1/worktree/spacemit-imgproc-canny_scharr_sobel/opencv/hal/riscv-rvv/src/imgproc/sobel.cpp:1051:48: warning: declaration of 'vrowx' shadows a previous local [-Wshadow]
1051 | vint16m8_t vrowx = __riscv_vle16_v_i16m8(target_trow + x, vl);
| ^~~~~
/home/tao/workspace/fytao/k1/worktree/spacemit-imgproc-canny_scharr_sobel/opencv/hal/riscv-rvv/src/imgproc/sobel.cpp:884:40: note: shadowed declaration is here
884 | vint16m8_t vrowx;
| ^~~~~
/home/tao/workspace/fytao/k1/worktree/spacemit-imgproc-canny_scharr_sobel/opencv/hal/riscv-rvv/src/imgproc/sobel.cpp:1868:48: warning: declaration of 'vrowx' shadows a previous local [-Wshadow]
1868 | vint16m8_t vrowx = __riscv_vle16_v_i16m8(target_trow + x, vl);
| ^~~~~
/home/tao/workspace/fytao/k1/worktree/spacemit-imgproc-canny_scharr_sobel/opencv/hal/riscv-rvv/src/imgproc/sobel.cpp:1710:40: note: shadowed declaration is here
1710 | vint16m8_t vrowx;
| ^~~~~
/home/tao/workspace/fytao/k1/worktree/spacemit-imgproc-canny_scharr_sobel/opencv/hal/riscv-rvv/src/imgproc/sobel.cpp:2679:50: warning: declaration of 'vrowx' shadows a previous local [-Wshadow]
2679 | vfloat32m8_t vrowx = __riscv_vle32_v_f32m8(target_trow + x, vl);
| ^~~~~
/home/tao/workspace/fytao/k1/worktree/spacemit-imgproc-canny_scharr_sobel/opencv/hal/riscv-rvv/src/imgproc/sobel.cpp:2519:42: note: shadowed declaration is here
2519 | vfloat32m8_t vrowx;
| ^~~~~
Besides, sanity checks failed from performance testings. Check with
# Get opencv_extra
git clone https://github.com/opencv/opencv_extra
export OPENCV_TEST_DATA_PATH=/path/to/opencv_extra/testdata
./build/bin/opencv_perf_imgproc --gtest_filter="*Img_Aperture_L2_thresholds*:*scharr*:*sobel*"
|
@damon-spacemit Friendly reminder |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.