Content-Length: 255451 | pFad | https://github.com/plotly/plotly.js/pull/7314

E6 [Bugfix Backport] Fix Container Height by samhinshaw · Pull Request #7314 · plotly/plotly.js · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix Backport] Fix Container Height #7314

Merged
merged 3 commits into from
Dec 14, 2024
Merged

[Bugfix Backport] Fix Container Height #7314

merged 3 commits into from
Dec 14, 2024

Conversation

samhinshaw
Copy link
Contributor

@samhinshaw samhinshaw commented Dec 14, 2024 •
edited by archmoj
Loading

Backport of #7313 for plotly.js v2.

Fixes #7312.
@plotly/plotly_js

@samhinshaw samhinshaw requested review from archmoj and removed request for archmoj December 14, 2024 01:09
@samhinshaw samhinshaw mentioned this pull request Dec 14, 2024
Merged
@archmoj archmoj marked this pull request as ready for review December 14, 2024 02:38
@archmoj
Copy link
Contributor

archmoj commented Dec 14, 2024

Thanks very much @samhinshaw for your help in catching the bug as well as this PR.
It was a great experience pair programming with you on this issue as well as on other upcoming PRs that we will merge into the master branch (as part of the v3 release).
FYI - I tested your proposed fix on CircleCI on top of the master branch and all the tests pass.
https://app.circleci.com/pipelines/github/plotly/plotly.js/11732/workflows/9e1ac8eb-ee34-48b3-a450-78e65818d1fd?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link&utm_content=summary

Therefore I move forward and merge this PR into the v2 branch, then release v2.35.3 patch to unblock the DE release.
Thank you!
And have a good weekend.

@archmoj archmoj merged commit 57a2214 into v2 Dec 14, 2024
1 check failed
@archmoj archmoj deleted the bugfix/backport-set-container-height branch December 14, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archmoj archmoj archmoj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samhinshaw @archmoj








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/plotly/plotly.js/pull/7314

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy