Content-Length: 296470 | pFad | https://github.com/projectdiscovery/proxify/pull/82

C1 Fix for cert endpoint not working + Internal engine by Mzack9999 · Pull Request #82 · projectdiscovery/proxify · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for cert endpoint not working + Internal engine #82

Merged
merged 5 commits into from
Dec 28, 2021
Merged

Fix for cert endpoint not working + Internal engine #82

merged 5 commits into from
Dec 28, 2021

Conversation

Mzack9999
Copy link
Member

@Mzack9999 Mzack9999 commented Dec 22, 2021 •
edited
Loading

Proposed changes

This PR fixes various issues in proxify engine causing side effects such as the cert endpoint not working or random failures during requests dispatching (draft)

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Reproduction Steps

  • Run proxify:
go run . -verbose
  • Run any client and point to proxify as the proxy:
$ curl -x http://127.0.0.1:8888 https://192.168.1.1 -k -I
HTTP/1.1 200 OK
...

@Mzack9999 Mzack9999 marked this pull request as draft December 22, 2021 12:21
@Mzack9999 Mzack9999 marked this pull request as ready for review December 22, 2021 13:02
@Mzack9999 Mzack9999 linked an issue Dec 22, 2021 that may be closed by this pull request
HTTP endpoint to download certificate (http://proxify/cacert.crt) is not working #77
Closed
@Mzack9999 Mzack9999 self-assigned this Dec 22, 2021
@Mzack9999 Mzack9999 added Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Dec 22, 2021
@xu-xiang
Copy link 

2021/12/24 02:44:37 [247] WARN: Cannot write TLS response header from mitm'd client: write tcp 127.0.0.1:8888->127.0.0.1:52231: write: broken pipe

@Mzack9999
Copy link
Member Author

@xu-xiang This looks like a different issue, were you trying to access a web application bound to localhost:52231? Can you provide reproduction steps?

@Mzack9999 Mzack9999 requested a review from ehsandeep December 27, 2021 07:07
@ehsandeep ehsandeep merged commit 0ff7fc7 into dev Dec 28, 2021
@ehsandeep ehsandeep deleted the issue-77-cert-endpoint branch December 28, 2021 17:58
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuitelSamikshya LuitelSamikshya LuitelSamikshya approved these changes

@ehsandeep ehsandeep ehsandeep approved these changes

Assignees

@Mzack9999 Mzack9999

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTTP endpoint to download certificate (http://proxify/cacert.crt) is not working
4 participants
@Mzack9999 @xu-xiang @ehsandeep @LuitelSamikshya








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/projectdiscovery/proxify/pull/82

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy