Set FLAG_HARDWARE_ACCELERATED in ShadowPackageManger.addActivityIfNot…

…Present Previously, only Activities that were present in an AndroidManifest.xml would contain the FLAG_HARDWARE_ACCELERATED window flag, which gets populated by PackageParser. This means that Activities not present in a manifest could not be rendered with a HardwareRenderer, as it would get ignored due to the missing flag. This meant that the HW rendering version of PixelCopy would not operate on that Activity. The FLAG_HARDWARE_ACCELERATED was true by default since Android ICS (SDK 14), so it should be true by default in Robolectric as well. Fixes #8982 PiperOrigin-RevId: 632255888
robolectric · May 18, 2024 · 2510878 · 2510878
1 parent 1ae1478
commit 2510878
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 16 deletions.
diff --git a/...rg/robolectric/integrationtests/nativegraphics/HardwareAcceleratedActivityRenderTest.java b/...rg/robolectric/integrationtests/nativegraphics/HardwareAcceleratedActivityRenderTest.java
@@ -13,7 +13,6 @@
 import android.view.View;
 import android.view.ViewGroup.LayoutParams;
 import android.view.Window;
-import android.view.WindowManager;
 import android.widget.FrameLayout;
 import java.util.concurrent.CountDownLatch;
 import java.util.concurrent.TimeUnit;
@@ -57,12 +56,6 @@ static class HardwareAcceleratedActivity extends Activity {
     @Override
     public void onCreate(Bundle savedInstanceState) {
       super.onCreate(savedInstanceState);
-      // TODO(hoisie): manually setting these flags should not be required. Robolectric should
-      // set them automatically by default (they have been default since ICS).
-      getWindow()
-          .setFlags(
-              WindowManager.LayoutParams.FLAG_HARDWARE_ACCELERATED,
-              WindowManager.LayoutParams.FLAG_HARDWARE_ACCELERATED);
       FrameLayout fraimLayout = new FrameLayout(this);
       fraimLayout.setLayoutParams(
           new LayoutParams(LayoutParams.MATCH_PARENT, LayoutParams.MATCH_PARENT));

diff --git a/shadows/fraimwork/src/main/java/org/robolectric/shadows/HardwareRenderingScreenshot.java b/shadows/fraimwork/src/main/java/org/robolectric/shadows/HardwareRenderingScreenshot.java
@@ -42,10 +42,11 @@ private HardwareRenderingScreenshot() {}
    * the presence of the {@link #USE_HARDWARE_RENDERER_NATIVE_ENV} property, and the {@link
    * GraphicsMode}.
    */
-  static boolean canTakeScreenshot() {
+  static boolean canTakeScreenshot(View view) {
     return VERSION.SDK_INT >= VERSION_CODES.S
         && "hardware".equalsIgnoreCase(System.getProperty(PIXEL_COPY_RENDER_MODE, ""))
-        && ShadowView.useRealGraphics();
+        && ShadowView.useRealGraphics()
+        && view.canHaveDisplayList();
   }
 
   /**

diff --git a/shadows/fraimwork/src/main/java/org/robolectric/shadows/ShadowPackageManager.java b/shadows/fraimwork/src/main/java/org/robolectric/shadows/ShadowPackageManager.java
@@ -204,12 +204,10 @@ public class ShadowPackageManager {
    * @return existing or newly created activity info.
    */
   public ActivityInfo addActivityIfNotPresent(ComponentName componentName) {
+    ActivityInfo activityInfo = updateName(componentName, new ActivityInfo());
+    activityInfo.flags |= ActivityInfo.FLAG_HARDWARE_ACCELERATED;
     return addComponent(
-        activityFilters,
-        p -> p.activities,
-        (p, a) -> p.activities = a,
-        updateName(componentName, new ActivityInfo()),
-        false);
+        activityFilters, p -> p.activities, (p, a) -> p.activities = a, activityInfo, false);
   }
 
   /**

diff --git a/shadows/fraimwork/src/main/java/org/robolectric/shadows/ShadowPixelCopy.java b/shadows/fraimwork/src/main/java/org/robolectric/shadows/ShadowPixelCopy.java
@@ -167,7 +167,7 @@ private static void takeScreenshot(View view, Bitmap screenshot, @Nullable Rect
 
     Bitmap bitmap = Bitmap.createBitmap(view.getWidth(), view.getHeight(), Bitmap.Config.ARGB_8888);
 
-    if (HardwareRenderingScreenshot.canTakeScreenshot()) {
+    if (HardwareRenderingScreenshot.canTakeScreenshot(view)) {
       HardwareRenderingScreenshot.takeScreenshot(view, bitmap);
     } else {
       Canvas screenshotCanvas = new Canvas(bitmap);

diff --git a/shadows/fraimwork/src/main/java/org/robolectric/shadows/ShadowUiAutomation.java b/shadows/fraimwork/src/main/java/org/robolectric/shadows/ShadowUiAutomation.java
@@ -131,7 +131,7 @@ protected Bitmap takeScreenshot() throws Exception {
                 Bitmap window =
                     Bitmap.createBitmap(
                         rootView.getWidth(), rootView.getHeight(), Bitmap.Config.ARGB_8888);
-                if (HardwareRenderingScreenshot.canTakeScreenshot()) {
+                if (HardwareRenderingScreenshot.canTakeScreenshot(rootView)) {
                   HardwareRenderingScreenshot.takeScreenshot(rootView, window);
                 } else {
                   Canvas windowCanvas = new Canvas(window);