Improve the fidelity of legacy SQLite error messages #8615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
piper_582331582
branch
from
8fa37a8 to
4de9408
Compare
Previously, in the legacy SQLite mode, all exceptions thrown by SQLite were wrapped in an arbitrary RuntimeExceptions. This is not consistent with real Android, which always throws exceptions of type android.database.sqlite.SQLiteException (including subclasses). This has impact on data layer libraries such as Room that explicitly catch Android SQLiteExceptions in order to execute error callback logic. For #8469 PiperOrigin-RevId: 582557176
copybara-service
bot
force-pushed
the
piper_582331582
branch
from
4de9408 to
bfb00f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the fidelity of legacy SQLite error messages
Previously, in the legacy SQLite mode, all exceptions thrown by SQLite were
wrapped in an arbitrary RuntimeExceptions. This is not consistent with real
Android, which always throws exceptions of type
android.database.sqlite.SQLiteException (including subclasses). This has impact
on data layer libraries such as Room that explicitly catch Android
SQLiteExceptions in order to execute error callback logic.
For #8469