Don't use isUserKeyUnlocked() after Android 14 #8635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TestApi StorageManager#isUserKeyUnlocked() is being superseded by StorageManager#isCeStorageUnlocked(). Since isUserKeyUnlocked() will soon have no callers other than robolectric, the plan is to remove it. This commit unblocks that plan by making robolectric stop depending on this method at build time.
utzcoz
approved these changes
Nov 22, 2023
|
@ebiggers Thanks. |
utzcoz
reviewed
Nov 22, 2023
| // Use reflection, as this method is planned to be removed from StorageManager in V. | ||
| assertThat( | ||
| (boolean) | ||
| ReflectionHelpers.callStaticMethod( |
There was a problem hiding this comment.
@hoisie I remember that we can use reflector here?
There was a problem hiding this comment.
Eh it's okay to use ReflectionHelpers for now, reflector is more of an optimization, but it won't matter too much here.
There was a problem hiding this comment.
Only converting to reflector when we find issues?
utzcoz
reviewed
Nov 22, 2023
robolectric/src/test/java/org/robolectric/shadows/ShadowStorageManagerTest.java
Show resolved
Hide resolved
hoisie
approved these changes
Nov 22, 2023
hoisie
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TestApi StorageManager#isUserKeyUnlocked() is being superseded by StorageManager#isCeStorageUnlocked(). Since isUserKeyUnlocked() will soon have no callers other than robolectric, the plan is to remove it. This commit unblocks that plan by making robolectric stop depending on this method at build time.