-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Try to enable Emulator testing with SDK 34 again #9047
ci: Try to enable Emulator testing with SDK 34 again #9047
Conversation
@MGaetan89 @hoisie Looks like RotionalTest can't work with SDK34 Emulator. |
Looking at the source of @UnsupportedAppUsage(maxTargetSdk = Build.VERSION_CODES.R, trackingBug = 170729553)
private final int mNumerator;
@UnsupportedAppUsage(maxTargetSdk = Build.VERSION_CODES.R, trackingBug = 170729553)
private final int mDenominator; Our I don't know if there is a way to bypass this restriction on Robolectric side. Or if we should only run the tests that use |
It is not failed when running it with Robolectric, and it is failed when running in Android Emulator as there are hidden API restrictions. We might need to bypass this restriction when running tests. I am trying it locally. |
@MGaetan89 Because AOSP CTS disables hidden-api checking for |
338eab8
to
0dd7144
Compare
Rational#mNumerator and Rational#mDenominator are restricted accessed from SDK S, and we can't bypass it with Test Orchestrator + --no-hidden-api-checks. So this CL just running illegal Rational serialization tests under Android S to make it stable. Signed-off-by: utzcoz <utzcoz@outlook.com>
We have set the density to 240 for Emulators, and we can try to enable it for SDK 34 again to test stability. Signed-off-by: utzcoz <utzcoz@outlook.com>
0dd7144
to
e5ab4f4
Compare
@MGaetan89 I made a new CL to run illegal serialization only on devices before Android S. |
@MGaetan89 @hoisie Let's land SDK 34 Emulator testing again to capture potential compatibility issues like RationalTest. |
We have set the density to 240 for Emulators, and we can try to enable it for SDK 34 again to test stability.