Add support for RangingResult.Builder in ShadowRangingResult for V. #9325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
piper_651458525
branch
3 times, most recently
from
9466277 to
ad6d039
Compare
In U and below, RangingResult had a large constructor in android. Robolectric created a builder for this in the shadow. In Android V, this code now has a builder in the Android code and no longer has a constructor available. Thus, this change keeps the shadow's builder and then builds it using the builder in Android. It's not available for direct usage, so reflection is used to access it. PiperOrigin-RevId: 653699509
copybara-service
bot
force-pushed
the
piper_651458525
branch
from
ad6d039 to
d1937fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for RangingResult.Builder in ShadowRangingResult for V.
In U and below, RangingResult had a large constructor in android.
Robolectric created a builder for this in the shadow. In Android V,
this code now has a builder in the Android code and no longer has a
constructor available. Thus, this change keeps the shadow's builder
and then builds it using the builder in Android. It's not available
for direct usage, so reflection is used to access it.