Content-Length: 351977 | pFad | https://github.com/rpgeeganage/async-ray/pull/20

C1 V3.1.0 by rpgeeganage · Pull Request #20 · rpgeeganage/async-ray · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3.1.0 #20

Merged
merged 19 commits into from
Dec 26, 2018
Merged

V3.1.0 #20

merged 19 commits into from
Dec 26, 2018

Conversation

rpgeeganage
Copy link
Owner

@rpgeeganage rpgeeganage commented Dec 25, 2018

Todo:

  • Need to update Read Me

New features:

  1. Added Chainable functionality to support to chain async function. (Except aForEach)
    https://github.com/rpgeeganage/async-ray/blob/f61a3856089a313ee94b09de133f5611c56ea206/test/chainable.ts

  2. Exported individual methods to use independently.
    https://github.com/rpgeeganage/async-ray/blob/f61a3856089a313ee94b09de133f5611c56ea206/test/individual.ts

@rpgeeganage rpgeeganage added the New feature / request New feature or request label Dec 25, 2018
lib/chainable.ts Outdated Show resolved Hide resolved
lib/chainable.ts Outdated Show resolved Hide resolved
* @returns {Promise<any>}
* @memberof Chainable
*/
async process(): Promise<any> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would favour an implementation without this method (at least without requirement to always call it - might be inconvenient and people may forget to call process and thus wonder what is wrong).
A flag (with default value) in the constructor could determine whether the call to process is needed or not. With that one would have the freedom do define the chain earlier and process it at a certain point by calling process explicitly. Defaultly the processing should immediately start.

Copy link
Owner Author

@rpgeeganage rpgeeganage Dec 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would you suggest to trigger the processing the chain ?
I saw the same approach in Lodash, when we chain, we have to call the value() method to get the final value.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New implementation, does not require to call if the last method does not return an array.

@rpgeeganage rpgeeganage merged commit 9247dfb into master Dec 26, 2018
@rpgeeganage rpgeeganage deleted the v3.1.0 branch December 26, 2018 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New feature / request New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/rpgeeganage/async-ray/pull/20

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy