-
-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ci/cd error #195
fix ci/cd error #195
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! it seems there is still a file missing, though, according to the CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Seems like a lot of work.
Are these changes in the comments necessary ##-------
-> ## ------
(notice the extra whitespace after ##
)?
Without those there would be many fewer changes in this PR.
If there are no spaces after the # sign, it will also report code formatting errors
|
I see. Thanks for the clarification. |
Yes, it seems that Ruby has a requirement for whitespace. |
Thanks! That has worked but I still see a lot of |
Right, It seems much less now, just adding spaces to the Ruby files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you for your work!
Description
Related Issue: CC #184
Pre-commit steps
./contributor_setup.sh
followed by./devtool ready_for_publish
Ruby
withBundler
andNPM
installed locally../devtool ready_for_publish_no_rust
can be used instead (faster).What did this PR do
The following things were done to fix this error:
bundle exec ruby utils/devtool.rb copyright
.settings.json
file and addprettierrc. json
. If the code format is not followed, it will cause Github CI to run error when runningbundle exec ruby utils/devtool.rb fmt_check
.i.to_s ->i
It does not need to be called explicitly, which will cause Github CI to error when runningbundle exec ruby utils/devtool.rb rubocop
Because I need to check many files, I cannot manually modify them one by one. I will replace them in bulk and finally convert the code format.
CC @eldruin @andre-richter