[master] Fix 64433: Add dynamic loading of file_roots, pillar_roots, and thorium_roots #64434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluesliverx
force-pushed
the
dynamic-roots
branch
from
d98a6c9 to
01f7eb3
Compare
Ch3LL
suggested changes
Jun 8, 2023
bluesliverx
force-pushed
the
dynamic-roots
branch
from
53f0ce3 to
6f71681
Compare
|
@Ch3LL I have added tests and updated the documentation as requested. Let me know if you see anything else. |
|
@twangboy, this is ready now I believe. |
twangboy
approved these changes
Mar 25, 2025
dmurphy18
approved these changes
Mar 25, 2025
|
How does one go about getting this merged? :) |
|
I'm thinking we'll get things fixed on 3006.x and 3007.x, then merge those forward into master. Then we can rebase and get this in. |
added 8 commits
May 9, 2025 13:16
|
@twangboy sorry to be annoying, any update on getting this merged in? Just curious. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds dynamic expansion of file/pillar/thorium roots config.
What issues does this PR fix or reference?
Fixes: #64433
Previous Behavior
The roots were expanded only once at startup.
New Behavior
The roots are expanded on every access of the environments within the
file_roots,pillar_roots, andthorium_rootsoptions.Merge requirements satisfied?
Commits signed with GPG?
No