Content-Length: 457172 | pFad | https://github.com/saltstack/salt/pull/67919

83 Prepend cmd when using built-in commands on Windows by twangboy · Pull Request #67919 · saltstack/salt · GitHub
Skip to content

Prepend cmd when using built-in commands on Windows #67919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
May 27, 2025

Conversation

twangboy
Copy link
Contributor

@twangboy twangboy commented Mar 24, 2025

What does this PR do?

Fixes an issue with running commands on Windows using cmd.run. Some commands are built-in commands only available when run from a cmd prompt. This checks for a binary for the command. If the binary does not exist, it is assumed that this is a built-in command and prepends cmd /c to the command. There are also some operators built-in to cmd such as && and ||. If those are present and the command does not start with cmd, it will be prepended.

What issues does this PR fix or reference?

Fixes #54821

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

@twangboy twangboy requested a review from a team as a code owner March 24, 2025 19:58
@twangboy twangboy self-assigned this Mar 24, 2025
@twangboy twangboy added this to the Sulfur v3006.11 milestone Mar 24, 2025
dmurphy18
dmurphy18 previously approved these changes Mar 24, 2025
@twangboy twangboy added the test:full Run the full test suite label Mar 25, 2025
@twangboy twangboy mentioned this pull request Apr 23, 2025
17 tasks
@dwoz dwoz merged commit 2a23ade into saltstack:3006.x May 27, 2025
2762 of 2765 checks passed
@xsmile xsmile mentioned this pull request Jul 17, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test:full Run the full test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/saltstack/salt/pull/67919

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy