Content-Length: 398405 | pFad | https://github.com/saltstack/salt/pull/68157

3F win_runas fixes/enhancements by xsmile · Pull Request #68157 · saltstack/salt · GitHub
Skip to content

win_runas fixes/enhancements #68157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: 3007.x
Choose a base branch
from
Open

win_runas fixes/enhancements #68157

wants to merge 6 commits into from

Conversation

xsmile
Copy link

@xsmile xsmile commented Jul 7, 2025

What does this PR do?

Unify result processing for timed_subprocess.TimedProc and win_runas.runas

  • use the same code path for both functions
  • fix stdout/stderr decoding exceptions with runas as previously UTF-8 was assumed

win_runas.runas and win_runas.runas_unpriv

  • support the parameter env to pass custom environment variables
  • support the parameter redirect_stderr to redirect stderr to stdout
  • support the parameter timeout to abort execution and kill the process after a timeout
  • support the parameter bg to run a command in background without waiting for the result
  • ensure opened handles are closed

Merge requirements satisfied?

Commits signed with GPG?

No

@xsmile
Copy link
Author

xsmile commented Jul 10, 2025

Fixed tests and formatting, added a changelog.

Copy link
Contributor

@twangboy twangboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changelog. Just asking that we document the kwarg bg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-changelog test:full Run the full test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/saltstack/salt/pull/68157

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy