Content-Length: 295493 | pFad | https://github.com/sebadob/rauthy/pull/601

00 rework migrations between differerent databases by sebadob · Pull Request #601 · sebadob/rauthy · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework migrations between differerent databases #601

Merged
merged 13 commits into from
Nov 6, 2024

Conversation

sebadob
Copy link
Owner

@sebadob sebadob commented Nov 4, 2024

This is a follow-up issue for the migration to Hiqlite.

It will take care of the migrations between different databases. The whole MIGRATE_DB_FROM will be reworked internally to make it less error prone and work with Hiqlite.

@sebadob sebadob marked this pull request as draft November 4, 2024 10:48
@sebadob
Copy link
Owner Author

sebadob commented Nov 6, 2024

The following migrations have been tested and are working now:

  • sqlite -> hiqlite
  • sqlite -> postgres
  • hiqlite (sqlite) -> postgres
  • postgres -> hiqlite

@sebadob
Copy link
Owner Author

sebadob commented Nov 6, 2024

The migrations are working fine.

At the current stage, Rauthy will always create (and need) a Postgres connection, even when using Hiqlite.
This is due to the design from before and the connection pool being inside the AppState.
This needs to be dropped and moved out, which is already prepared, but dropping it completely will result in many things that need fixing, so this will be done in another PR again.

@sebadob sebadob marked this pull request as ready for review November 6, 2024 09:40
@sebadob sebadob merged commit dac3892 into main Nov 6, 2024
@sebadob sebadob deleted the feat-migrations-between-dbs branch November 6, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/sebadob/rauthy/pull/601

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy