Content-Length: 252243 | pFad | https://github.com/simpeg/simpeg/pull/1471

ED Hide type hints from signatures in documentation pages by santisoler · Pull Request #1471 · simpeg/simpeg · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide type hints from signatures in documentation pages #1471

Merged
merged 3 commits into from
Jun 14, 2024

Conversation

santisoler
Copy link
Member

Summary

Configure Sphinx autodoc to hide type hints from signatures of functions, methods and classes to improve readability. Expected types for each parameter should be listed in the docstring.

PR Checklist

  • If this is a work in progress PR, set as a Draft PR
  • Linted my code according to the style guides.
  • Added tests to verify changes to the code.
  • Added necessary documentation to any new functions/classes following the
    expect style.
  • Marked as ready for review (if this is was a draft PR), and converted
    to a Pull Request
  • Tagged @simpeg/simpeg-developers when ready for review.

Reference issue

What does this implement/fix?

Additional information

Configure Sphinx autodoc to hide type hints from signatures of
functions, methods and classes to improve readability. Expected types
for each parameter should be listed in the docstring.
Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.33%. Comparing base (00d3371) to head (509d21d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1471   +/-   ##
=======================================
  Coverage   82.33%   82.33%           
=======================================
  Files         171      171           
  Lines       26027    26027           
=======================================
  Hits        21430    21430           
  Misses       4597     4597           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@santisoler santisoler changed the title Hide type hints from signatures Hide type hints from signatures in documentation pages May 23, 2024
@santisoler santisoler marked this pull request as ready for review June 13, 2024 16:42
@santisoler santisoler added this to the 0.22.0 milestone Jun 14, 2024
@santisoler santisoler merged commit 0782567 into main Jun 14, 2024
18 checks passed
@santisoler santisoler deleted the no-type-hints-docs branch June 14, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/simpeg/simpeg/pull/1471

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy