Add VERSIONINFO for Windows executable #1387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Good idea. I have no clue personally as to whether this will negatively affect anything else (eg non-windows), but we can give it a go. 😄 With the Travis failure, it looks like one of the two compile tests worked fine (good), but the other failed due to Travis infrastructure problems. eg nothing to do with this PR. I'll merge this now, and we can look over the resulting Windows builds tomorrow to make sure they're good + fine tune things a bit if needed. 😄 |
|
Yes, it is just a Windows thing. The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.