Content-Length: 359661 | pFad | https://github.com/sqlitebrowser/sqlitebrowser/pull/666

87 Load window settings at the start of init by vtronko · Pull Request #666 · sqlitebrowser/sqlitebrowser · GitHub
Skip to content

Load window settings at the start of init #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2016
Merged

Load window settings at the start of init #666

merged 1 commit into from
Jul 21, 2016

Conversation

vtronko
Copy link
Member

@vtronko vtronko commented Jul 21, 2016

I suggest to load preferences right in the very beginning of init method.
Particularly in case of #664

restoreState(PreferencesDialog::getSettingsValue("MainWindow", "windowState").toByteArray());

code is running after

ui->dockEditWindow->hide();     // Hidden by default

which is not cool 😄

This PR fixes the issue I addressed in this comment, but I believe, this will fix the #664 itself.
Test this, please, and tell if it works.

@justinclift
Copy link
Member

Cool, this definitely makes sense. I'll test it here in a few minutes. 😄

@vtronko
Copy link
Member Author

vtronko commented Jul 21, 2016

@justinclift 666 pull request should always make sense 😄

@justinclift justinclift merged commit ee9dbac into sqlitebrowser:master Jul 21, 2016
@justinclift
Copy link
Member

justinclift commented Jul 21, 2016 •
edited
Loading

Thanks @innermous . You're right, this fixes #664 too. 😄

@justinclift justinclift added the bug Confirmed bugs or reports that are very likely to be bugs. label Jul 21, 2016
@justinclift
Copy link
Member

Found an interesting side effect from this PR, it's causing the window geometry for the Edit Cell dock to change, and some of the buttons to become partially hidden.

Investigating now. I think it'll be a fairly simple fix. 😄

@vtronko
Copy link
Member Author

vtronko commented Jul 21, 2016

@justinclift alright.
It's all about order, really 😄

@justinclift
Copy link
Member

Yeah, this is weird:

screen shot 2016-07-21 at 15 54 24

It's definitely the restoreGeometry() and restoreState() calls having the effect. Exploring possible solutions atm, but not quite figured it out yet. 😉

@vtronko
Copy link
Member Author

vtronko commented Jul 21, 2016

I can't reproduce it.
I just open last database, click on random cell, and all buttons are active, nothing like what you shown.

@vtronko
Copy link
Member Author

vtronko commented Jul 21, 2016 •
edited
Loading

@justinclift I am sorry, haven't tested it enough :c
You are sure that you are not in detached state and haven't done any changes?

@justinclift
Copy link
Member

justinclift commented Jul 21, 2016 •
edited
Loading

Was testing it with #665 on top. For some unknown reason, there's a bad interaction. I'm not sure why.

At the moment I'm putting more time into #621 again. That's probably going to take up the next few hours. 😫

@vtronko
Copy link
Member Author

vtronko commented Jul 21, 2016

@justinclift but my stand-alone commit is doing fine, right?

@justinclift
Copy link
Member

Yep. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vtronko vtronko

Labels
bug Confirmed bugs or reports that are very likely to be bugs.
Projects
None yet
Milestone
3.9.0 - Something Nifty Treads Here L...
Development

Successfully merging this pull request may close these issues.
2 participants
@vtronko @justinclift








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/sqlitebrowser/sqlitebrowser/pull/666

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy