Implement basic soft deletion for workspaces #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this adds a `deleted_at` column to workspaces that implements a basic soft-deletion mechanism. All relevant queries have been modified to reflect this. At the moment, there is no hard deletion of workspaces; this will be implemented in the future. We also have no way of showing "archived" or "soft-deleted" workspaces. This will come in due time. Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
aponcedeleonch
requested changes
Jan 20, 2025
aponcedeleonch
previously approved these changes
Jan 20, 2025
Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
|
I'm getting |
Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
| except crud.WorkspaceDoesNotExistError: | ||
| return f"Workspace **{workspace_name}** does not exist" | ||
| except Exception: | ||
| return "An error occurred while removing the workspace" |
There was a problem hiding this comment.
We should give the user a clearer error message of what's going on. I got this when trying to delete the active workspace. It's ok to fix on a later PR.
There was a problem hiding this comment.
Can you open a bug about this? I can fix it tomorrow.
aponcedeleonch
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds a
deleted_atcolumn to workspaces that implements a basicsoft-deletion mechanism. All relevant queries have been modified to reflect this.
At the moment, there is no hard deletion of workspaces; this will be
implemented in the future.
We also have no way of showing "archived" or "soft-deleted" workspaces.
This will come in due time.
Signed-off-by: Juan Antonio Osorio ozz@stacklok.com