Content-Length: 354990 | pFad | https://github.com/starship/starship/issues/4048

3F feat: add Raku module by sergot · Pull Request #4048 · starship/starship · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Raku module #4048

Merged
merged 2 commits into from
Jun 26, 2022
Merged

feat: add Raku module #4048

merged 2 commits into from
Jun 26, 2022

Conversation

sergot
Copy link
Contributor

@sergot sergot commented Jun 7, 2022

Implement a module to support Raku programming language, it prints the version (and the vm type it's built on) for Raku, for example: 🦋 v6.d-moar. 🦋 (a butterfly) is Raku's logo called Camelia.

I followed the checklist from CONTRIBUTING.md.

Description

Motivation and Context

As a developer who likes to code using Raku language, I'd like to see the current version of raku in the command line.

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@sergot
Copy link
Contributor Author

sergot commented Jun 8, 2022

I'll fix the Dprint issue today.

@sergot sergot force-pushed the add-raku-support branch from 3acf823 to 6a52c25 Compare June 8, 2022 10:31
Copy link
Member

@andytom andytom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looks like there are a few gaps in the test coverage can you update the tests to cover these.

@sergot
Copy link
Contributor Author

sergot commented Jun 15, 2022

Hi @andytom , I'd love to but it seems like it's not that easy to do, I went through other modules and haven't found a single one that covers these lines :(

e.g. https://app.codecov.io/gh/starship/starship/blob/master/src/modules/python.rs

src/modules/raku.rs Outdated Show resolved Hide resolved
@sergot sergot force-pushed the add-raku-support branch from 781c7ce to e9c4da6 Compare June 16, 2022 12:26
@sergot sergot force-pushed the add-raku-support branch from f6d37ac to 5b7dd89 Compare June 16, 2022 13:04
Copy link
Member

@andytom andytom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a little typo but other than that all good.

docs/config/README.md Outdated Show resolved Hide resolved
Co-authored-by: Thomas O'Donnell <andytom@users.noreply.github.com>
@davidkna davidkna merged commit 1a4fac6 into starship:master Jun 26, 2022
@davidkna
Copy link
Member

Thanks for the contribution @sergot, and thanks for helping to review this @andytom!

Indyandie pushed a commit to Indyandie/starship that referenced this pull request Jul 26, 2023
* feat: add Raku module

* Update docs/config/README.md

Co-authored-by: Thomas O'Donnell <andytom@users.noreply.github.com>

Co-authored-by: Thomas O'Donnell <andytom@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/starship/starship/issues/4048

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy