fix(timings): count time spent on custom on 'when' command failure #4121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know why the diff looks so weird, I just wrapped the rest of the function in an |
|
I had a quick look at testing since I realized that it wouldn't actually be necessary to sleep in a test, but currently the tests are purely based on checking the output, so to be able to verify that a module is returned that contains a duration but no output would require some test refactoring. |
davidkna
changed the title
davidkna
approved these changes
Jul 5, 2022
|
Thanks for handling this @majutsushi. |
This was referenced Aug 14, 2022
This was referenced Feb 25, 2023
This was referenced Apr 11, 2023
Indyandie
pushed a commit
to Indyandie/starship
that referenced
this pull request
Jul 26, 2023
…tarship#4121) Count time spent on custom 'when' commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Return a
Moduleinstance with timing information for custom modules even if thewhenexecution returnsfalse.Motivation and Context
Closes #4093.
Previously the custom module evaluation function would return early if the
whenexecution returnedfalse, but the timing information was only added when returning a module instance at the end of the function. This meant that slowwhencommands would invisibly slow down the prompt. This change causes the function to not return early in this case and instead return a proper module instance with timing information whether or not thewhencommand indicates that the module should be shown.How Has This Been Tested?
I tested this manually with the custom command I described in #4093. I wasn't sure whether I should add a test since it would probably need to have small sleep in it, which isn't ideal for unit tests. I did run the existing tests though.
Checklist: