feat(bug-report): ask for confirmation before opening issue #4543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkna
force-pushed
the
bug-report-confirmation
branch
2 times, most recently
from
040652b to
096ad65
Compare
davidkna
force-pushed
the
bug-report-confirmation
branch
from
096ad65 to
c1cc046
Compare
andytom
approved these changes
Nov 25, 2022
Co-authored-by: Thomas O'Donnell <andytom@users.noreply.github.com>
Well, I will keep using my local patch that removes this subcommand.
At least the confirmation should expect an uppercase You can avoid a little bit more complexity by saving the (long) report to a temporary file and link to the bug tracker. |
This was referenced Feb 25, 2023
This was referenced Apr 11, 2023
Indyandie
pushed a commit
to Indyandie/starship
that referenced
this pull request
Jul 26, 2023
…#4543) * feat(bug-report): ask for confirmation before opening issue * Apply suggestions from code review Co-authored-by: Thomas O'Donnell <andytom@users.noreply.github.com> Co-authored-by: Thomas O'Donnell <andytom@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Privacy concerns have been voiced about the privacy tool (#3757). To avoid any data from being exposed unintentionally, ask for confirmation before forwarding issue reports to GitHub.
Unlike #3794, this PR avoids complexity by simply asking for confirmation instead of allowing edits of generated reports.
Motivation and Context
Closes #3757
Closes #3794
Screenshots (if appropriate):
How Has This Been Tested?
Checklist: