fix: Parse arguments of $VISUAL and $EDITOR #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds *extensive* tests
|
How far down the rabbit hole can we go? |
8 tasks
|
Do you mind that I rebased from your branch? To be honest, I don't know another way to build upon an unmerged PR. |
|
Whatever you did, it seems to have worked |
matchai
approved these changes
Dec 23, 2019
There was a problem hiding this comment.
Looks good to me!
Thank you for the help @dominikbraun and @Scotsguy! 🙏😊
|
@all-contributors Please add @dominikbraun for code. 🎉 |
|
I've put up a pull request to add @dominikbraun! 🎉 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We thought that Issue #769 was a result of empty
$VISUALand/or$EDITORvariables, which were indeed a problem. However, the same error occurs when an environment variable contains arguments or options. This will causestarship configureto panic:While #770 fixes the bug for empty environment variables, this PR takes all options like
-minto account when executing the editor.Motivation and Context
Closes #769
Types of changes
How Has This Been Tested?
Checklist: