Update SVDs for STM32G0B1/C1 #666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burrbull
reviewed
Nov 22, 2021
| CNTR: | ||
| USBRST: | ||
| _replace_enum: | ||
| B_0x0: [0, "No effect"] |
There was a problem hiding this comment.
In such form enums are useful. Give them meaningful name.
There was a problem hiding this comment.
Thanks, should be better now.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As written in #641 (comment) I gave updating SVDs for STM32G0B1/C1 a try.
This should add the missing peripherals mentioned there and in #548.
I am not quite sure if removing the duplicate USB register enums counts as fixing the structure of the SVD or if it rather should live in the peripherals folders.