F7/tim: access to bits() without unsafe for single-field registers #700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any reason to close this? Is it already in another PR? |
|
I was sure I did a mistake since I forgot to cleanup some code that was using it in the F7 HAL, but it actually looks fine so I'll reopen it |
maximeborges
changed the title
adamgreig
approved these changes
Jul 3, 2022
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing to
CNT/ARR/CCR%ssingle-field registers viabits(), it requires the use of unsafe for timers 9 to 14.This PR allows to use safe
bits()writing just like the other timers