Make the gem compatible with Stripe Gem v.5 #658
Conversation
ghost
force-pushed
the
stripe-v5-compatability
branch
from
b031b37 to
23fb715
Compare
ghost
force-pushed
the
stripe-v5-compatability
branch
from
23fb715 to
06458c0
Compare
|
Hmm, the tests are all working locally ... Any ideas what I can do to make them work on Travis? |
|
Ran rubocop against the errors file to make the changes sugested by @vishnun |
ghost
mentioned this pull request
|
This has been open for over a month now ... Any chance to do something here? |
|
@ioki-klaus have you tried tagging @rebelidealist or @vishnun directly? Also there seems to be a chat at https://gitter.im/rebelidealist/stripe-ruby-mock |
|
Well I don't think the team here is not maintaining this anymore and there are other people working on this ... Also, I don't want to ping people directly. I am working with my own fork now and this is fine for me |
|
@ioki-klaus thank you very much! You made a wonderful and huge contribution! But if you want to help - don't need to wait for me for merging. There are a lot of work to be done with gem and I have my paid projects. Unfortunately, I have no enough time for support this gem. Initial owner doesn't work with ruby anymore and doesn't support this gem. Please, read this and get an access for merge/push/release. |
|
Hey @alexmamonchik, thanks for the reply. Yeah, I can totally understand your situation and that's why I also did not want to bother you (or other maintainers, if there are some) with asking you personally to look at this PR. I know the pains of maintaining an Open Source project :) I would like to contribute some more, with some conditions (like splitting the Stripe mock logic from the server into seperate gems, because the current implementation is very messy and hard to get up and running to test ... Requiring increasing I think @mnin might also be interested in contributing more ... How would you feel about setting up a chat or something? |
|
@ioki-klaus Thanks for your mention, yeah, I'd be interested to change more here, that's true. @alexmamonchik thanks for your work! I would prefer a new Slack workspace. |
ghost
mentioned this pull request
Hey there,
this PR is a work in progress to start making the Gem compatible with version 5 of the Stripe gem. Contrary to the implementation started in #643, I am explicitly dropping compatability with all lower gems. As discussed in #646 it is planned to release a version 3 of this gem anyways that will require Stripe 5.
I hope nobody else started working on this, I looked through the branches here, but did not check all 500 forks.
TODOs
StripeErrorimplementation to usecodeas a keyword argumenthttp_bodyas this should contain the unparsed JSON bodyalltolist(Remove all alias for list methods stripe/stripe-ruby#823)customer.invoice_items -> InvoiceItems.list(customer: customer.id)Migration Guide: https://github.com/stripe/stripe-ruby/wiki/Migration-guide-for-v5#removed-methods