Add missing response and requestFormat variable #450
Conversation
| @@ -61,7 +61,7 @@ protected function renderArticle(Request $request, ArticleInterface $object, $vi | |||
|
|
|||
| try { | |||
| if ($partial) { | |||
| $this->createResponse($request); | |||
| $response = $this->createResponse($request); | |||
There was a problem hiding this comment.
we should really enable phpstan in this repository..
alexander-schranz
added
the
bug
|
|
||
| /** | ||
| * This behavior has to be attached to documents which should have a sulu-route but managed by their parent. | ||
| */ | ||
| interface RoutablePageBehavior extends RoutableInterface, UuidBehavior, LocaleBehavior, StructureBehavior | ||
| interface RoutablePageBehavior extends RoutableInterface, UuidBehavior, LocaleBehavior, StructureBehavior, RoutableBehavior |
There was a problem hiding this comment.
@Prokyonn This needs a higher min requirement of sulu/sulu since when does RoutableBehavior exist ?
There was a problem hiding this comment.
@wachterjohannes @danrot this sounds like a bc break in sulu/sulu that it now errors and didn't error before.
There was a problem hiding this comment.
Oh okay this is a page tree route interface which we had not yet implemented in 2.0 before.
There was a problem hiding this comment.
Think #422 is the missing part here @luca-rath?
There was a problem hiding this comment.
Yes, this change will be introduced when #422 is merged. This should not be needed here i guess.
…okyonn/SuluArticleBundle into bugfix/fix-website-article-controller
|
|
||
| /** | ||
| * This behavior has to be attached to documents which should have a sulu-route but managed by their parent. | ||
| */ | ||
| interface RoutablePageBehavior extends RoutableInterface, UuidBehavior, LocaleBehavior, StructureBehavior | ||
| interface RoutablePageBehavior extends BaseRoutableBehavior |
There was a problem hiding this comment.
@Prokyonn why did you change this here? I don't think, that this is needed
There was a problem hiding this comment.
It is needed for some functional tests, but the rest of the PageTreeRoute will be fixed in your PR :) (#422)
There was a problem hiding this comment.
If changes needed here this can be done in #422 but currently this is needed that the CI is running without an interface error.
| @@ -24,7 +24,7 @@ | |||
| "jms/serializer-bundle": "^3.3", | |||
| "ongr/elasticsearch-bundle": "^5.2", | |||
| "ongr/elasticsearch-dsl": "~5.0 || ~6.0", | |||
| "sulu/sulu": "^2.0.3", | |||
| "sulu/sulu": "^2.0.5", | |||
There was a problem hiding this comment.
I would prefer requiring ^2.0.6, because 2.0.5 introduced a bug and 2.0.6 is just the fix for it. WDYT?
There was a problem hiding this comment.
The bug has nothing todo with article bundle so I keep this and will merge this as it is to fix the current state.
|
Will merge this one, hope we get #422 merged soon so the CI is running again without errors. |
What's in this PR?
Add missing variables for proper functionality.