Run tests with github actions #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luca-rath
requested review from
niklasnatter
and removed request for
niklasnatter
luca-rath
commented
Nov 30, 2020
luca-rath
force-pushed
the
feature/github-actions
branch
from
5b94b6e to
83224ca
Compare
|
you can see here https://github.com/sulu/SuluArticleBundle/runs/1474716362 and here https://app.circleci.com/pipelines/github/sulu/SuluArticleBundle/435/workflows/5dfb73d3-0403-419d-88ce-689ae7dd81bf/jobs/1054 that the pipeline passes, if browserkit 5.1 is installed |
niklasnatter
reviewed
Dec 1, 2020
niklasnatter
reviewed
Dec 1, 2020
README.md
Outdated
| <a href="https://circleci.com/gh/sulu/SuluArticleBundle/tree/master" target="_blank"> | ||
| <img src="https://img.shields.io/circleci/build/github/sulu/SuluArticleBundle/master.svg?label=circleci" alt="CircleCI build"> | ||
| </a> | ||
| <a href="https://scrutinizer-ci.com/g/sulu/SuluArticleBundle?b=master" target="_blank"> | ||
| <img src="https://scrutinizer-ci.com/g/sulu/SuluArticleBundle/badges/quality-score.png?b=master" alt="Scrutinizer code quality"> |
There was a problem hiding this comment.
not sure if it makes any difference, but i think i would use the the badges from shields.io for consistency 😇
http://shields.io/category/analysis
niklasnatter
reviewed
Dec 1, 2020
README.md
Outdated
| <img src="https://scrutinizer-ci.com/g/sulu/SuluArticleBundle/badges/quality-score.png?b=master" alt="Scrutinizer code quality"> | ||
| </a> | ||
| <a href="https://scrutinizer-ci.com/g/sulu/SuluArticleBundle?b=master" target="_blank"> | ||
| <img src="https://scrutinizer-ci.com/g/sulu/SuluArticleBundle/badges/coverage.png?b=master" alt="Code coverage"> |
There was a problem hiding this comment.
|
@nnatter This pipeline won't pass, because of |
|
Okay, going to trust you with that. Looks good otherwise 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Run tests with github actions
Why?
To get rid of travis