Content-Length: 313480 | pFad | https://github.com/sveltejs/svelte/pull/15437

F8 chore: re-use current active effect for toStore if it already exists by trueadm · Pull Request #15437 · sveltejs/svelte · GitHub
Skip to content

chore: re-use current active effect for toStore if it already exists #15437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Mar 4, 2025

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Mar 4, 2025

🦋 Changeset detected

Latest commit: d950577

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

Copy link
Contributor

github-actions bot commented Mar 4, 2025

Playground

pnpm add https://pkg.pr.new/svelte@15437

@paoloricciuti
Copy link
Member

I wonder if this is all we need to do tho: if we execute the teardown of the root before the component unmount it should still work even with the current code (we can still add this)...I'll look into it later

@trueadm trueadm marked this pull request as ready for review March 4, 2025 18:41
@trueadm
Copy link
Contributor Author

trueadm commented Mar 4, 2025

I wonder if this is all we need to do tho: if we execute the teardown of the root before the component unmount it should still work even with the current code (we can still add this)...I'll look into it later

The issue is that when we schedule work on an effect and they're in different roots, you'll have race conditions where one root will happen entirely before the other. So if one root is trying to manage the other root, then the timing of teardown is not going to be consistent.

@trueadm
Copy link
Contributor Author

trueadm commented Mar 4, 2025

A better fix #15439.

@trueadm trueadm deleted the toStore-fix2 branch March 4, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/sveltejs/svelte/pull/15437

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy