Content-Length: 356299 | pFad | https://github.com/testing-library/testing-library-docs/pull/988

44 docs: improve "Migrate from Enzyme" grammar and clarity by jakeboone02 · Pull Request #988 · testing-library/testing-library-docs · GitHub
Skip to content

docs: improve "Migrate from Enzyme" grammar and clarity #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 19, 2022
Merged

docs: improve "Migrate from Enzyme" grammar and clarity #988

merged 2 commits into from
Jan 19, 2022

Conversation

jakeboone02
Copy link
Contributor

This PR does the following to the RTL "Migrate from Enzyme" and "FAQ" pages:

  • Adds missing periods and other punctuation
  • Corrects formatting and grammar
  • Removes some inconsiderate language (e.g. "trivial")
  • Updates Jest syntax in Enzyme examples

eps1lon
eps1lon approved these changes Jan 17, 2022
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all great improvements, thank you! Will leave this open for a bit for others to chime in. If I forget to merge withing a week, feel free to ping me again.

@jakeboone02
Copy link
Contributor Author

If I forget to merge withing a week, feel free to ping me again.

Will do. Thanks!

timdeschryver
timdeschryver reviewed Jan 18, 2022
View reviewed changes
Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This definitely looks better.
I left a few comments to make it easier to read (in my opinion).
Let me know what you think, I'm not a native speaker so I might be wrong on this.

@jakeboone02 @timdeschryver
Apply suggestions from code review
13bdb90 
Co-authored-by: Tim Deschryver <28659384+timdeschryver@users.noreply.github.com>
@timdeschryver timdeschryver merged commit fa2513e into testing-library:main Jan 19, 2022
@timdeschryver
Copy link
Member

@all-contributors please add @jakeboone02 for docs

@allcontributors allcontributors bot mentioned this pull request Jan 19, 2022
Merged
@allcontributors
Copy link
Contributor

@timdeschryver

I've put up a pull request to add @jakeboone02! 🎉

@jakeboone02 jakeboone02 deleted the migrate-from-enzyme-grammar branch January 19, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon approved these changes

@timdeschryver timdeschryver timdeschryver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakeboone02 @timdeschryver @eps1lon








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/testing-library/testing-library-docs/pull/988

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy