fix(milvus): Added New Semantic Conventions for pymilvus MilvusClient Hybrid Search #2944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Changes requested ❌
Reviewed everything up to 4372453 in 1 minute and 59 seconds. Click for details.
- Reviewed
42lines of code in3files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. packages/opentelemetry-semantic-conventions-ai/opentelemetry/semconv_ai/__init__.py:205
- Draft comment:
The constant 'MILVUS_HYBRID_SEARCH_RESULT_COUNT' is defined twice (lines 205 and 213). Please remove or rename the duplicate to avoid ambiguity. - Reason this comment was not posted:
Marked as duplicate.
2. packages/opentelemetry-semantic-conventions-ai/opentelemetry/semconv_ai/__init__.py:212
- Draft comment:
The constant 'MILVUS_HYBRID_SEARCH_PARTITION_NAMES' is assigned the value 'db.milvus.hybrid_search.partition_names_count'. This appears inconsistent with the naming pattern and might be a copy-paste error. Please verify if this is intentional or if it should be corrected (e.g., to 'db.milvus.hybrid_search.partition_names'). - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_JD54LBJ3xMpwYMRw
You can customize 
packages/opentelemetry-semantic-conventions-ai/opentelemetry/semconv_ai/__init__.py
Outdated
Show resolved
Hide resolved
| MILVUS_HYBRID_SEARCH_OUTPUT_FIELDS_COUNT = "db.milvus.hybrid_search.output_fields_count" | ||
| MILVUS_HYBRID_SEARCH_PARTITION_NAMES_COUNT = "db.milvus.hybrid_search.partition_names_count" | ||
| MILVUS_HYBRID_SEARCH_TIMEOUT = "db.milvus.hybrid_search.timeout" | ||
| MILVUS_HYBRID_SEARCH_PARTITION_NAMES = "db.milvus.hybrid_search.partition_names_count" |
There was a problem hiding this comment.
The attribute MILVUS_HYBRID_SEARCH_PARTITION_NAMES is assigned the value db.milvus.hybrid_search.partition_names_count. This looks like a copy-paste error—likely it should use a distinct value (e.g. db.milvus.hybrid_search.partition_names).
Suggested change
| MILVUS_HYBRID_SEARCH_PARTITION_NAMES = "db.milvus.hybrid_search.partition_names_count" | |
| MILVUS_HYBRID_SEARCH_PARTITION_NAMES = "db.milvus.hybrid_search.partition_names" |
nirga
approved these changes
May 16, 2025
nirga
force-pushed
the
milvus-hybrid-search-semconv
branch
from
25ac267 to
73c4f5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2937
feat(instrumentation): ...orfix(instrumentation): ....Important
Added new semantic conventions for Milvus hybrid search and updated version to 0.4.9.
SpanAttributesin__init__.py.MILVUS_HYBRID_SEARCH_RESULT_COUNTinSpanAttributesin__init__.py.0.4.9inversion.pyandpyproject.toml.This description was created by
for 4372453. You can customize this summary. It will automatically update as commits are pushed.