fix(mcp): Added support for newer version of MCP #2956
Conversation
Signed-off-by: fali007 <felixpv007@gmail.com>
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Changes requested ❌
Reviewed everything up to ff941cd in 1 minute and 38 seconds. Click for details.
- Reviewed
38lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_ZMCsAewgwXEb6l8F
You can customize 
packages/opentelemetry-instrumentation-mcp/opentelemetry/instrumentation/mcp/instrumentation.py
Outdated
Show resolved
Hide resolved
packages/opentelemetry-instrumentation-mcp/opentelemetry/instrumentation/mcp/instrumentation.py
Outdated
Show resolved
Hide resolved
…umentation/mcp/instrumentation.py Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
…umentation/mcp/instrumentation.py Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
|
Can you please use this decorator: https://github.com/traceloop/openllmetry/blob/1648905598915776956ef46a077c8fb941094662/packages/opentelemetry-semantic-conventions-ai/opentelemetry/semconv_ai/utils.py In the instrumentation methods? So if there will be failures in the instrumentation it won't crash the user's app. |
Made the change @galkleinman |
💪 tests are failing now tho :X |
Signed-off-by: fali007 <felixpv007@gmail.com>
nirga
changed the title
| async def __aiter__(self) -> AsyncGenerator[Any, None]: | ||
| from mcp.types import JSONRPCMessage, JSONRPCRequest | ||
| from mcp.shared.message import SessionMessage |
There was a problem hiding this comment.
It appears that the 1.6.0 version of MCP doesn't have a message module within the mcp.shared module. This will result in a ModuleNotFoundError: No module named 'mcp.shared.message', causing the instrumentation of MCP 1.6.0 to fail. Could you please fix this to make it compatible with mcp version 1.6.0?
feat(instrumentation): ...orfix(instrumentation): ....This PR intends to add support for MCP version >1.6.0
Important
Adds support for MCP version >1.6.0 by updating
InstrumentedStreamReaderandInstrumentedStreamWriterto handleSessionMessageandJSONRPCMessage.instrumentation.py.__aiter__()inInstrumentedStreamReaderto handleSessionMessageandJSONRPCMessage.send()inInstrumentedStreamWriterto handleSessionMessageandJSONRPCMessage.from mcp.shared.message import SessionMessageininstrumentation.py.This description was created by
for ff941cd. You can customize this summary. It will automatically update as commits are pushed.