-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.9.0 #507
Merged
Merged
v1.9.0 #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if a undefined value is passed to remove, the whole FilesCollection will be removed because coffeescript to set a default value compare the argument passed to the function with '== null' to set the argument to {} I think the solution is to delete the default value and let the check fail if the argument is not a string or a object
Test if the selector passed to remove() is a String or Object else return 0
Update server.coffee
Add missing var self = this; to interceptDownload
Remove unnecessary var self = this; declaration
Update google cloud integration example
Allow `headers` to be passed as an option to FilesCollection#load
- No more CoffeeScript
- Compatibility with `meteor@1.5.2.2` - NPM and Atmosphere dependencies update - No more coffee and CoffeeScript - __Deprecated__: globally available `Meteor.Files` - Implemented: `disableUpload` - Disable file upload, useful for server only solutions, see updated [*Constructor* docs](https://github.com/VeliovGroup/Meteor-Files/wiki/Constructor) - Implemented: `disableDownload` - Disable file download (serving), useful for file management only solutions, see updated [*Constructor* docs](https://github.com/VeliovGroup/Meteor-Files/wiki/Constructor) - Minor fix in [Google Cloud Storage Integration](https://github.com/VeliovGroup/Meteor-Files/wiki/Google-Clo ud-Storage-Integration), big thanks to @amos-whitewolf , see #498 - Implemented: Custom headers in [`.load()` method (*updated*)](https://github.com/VeliovGroup/Meteor-Files/wiki/Load), thanks to @zwjcarter , see #501 - Move events interface to [`eventemitter3` package](https://github.com/primus/eventemitter3) - Solve #500 removing 25ms delay before setting `auth-token-cookie` for `protected` downloads, thanks to @vbelolapotkov for pointing this out. Not sure if this will help for initial issue which stated `First download attempt`, as Meteor's login is async and happens only after DDP connection is established. - Fix `this.user` in `onBeforeRemove` hook - Deprecate (*temporarily*) `throttle` option, not sure if it was working from the beginning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.