Content-Length: 287122 | pFad | https://github.com/veliovgroup/Meteor-Files/pull/507

9C v1.9.0 by dr-dimitru · Pull Request #507 · veliovgroup/Meteor-Files · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.9.0 #507

Merged
merged 16 commits into from
Oct 19, 2017
Merged

v1.9.0 #507

merged 16 commits into from
Oct 19, 2017

Conversation

dr-dimitru
Copy link
Member

No description provided.

Wait0x and others added 16 commits September 7, 2017 17:25
if a undefined value is passed to remove, the whole FilesCollection will be removed because coffeescript to set a default value compare the argument passed to the function with '== null' to set the argument to {}
I think the solution is to delete the default value and let the check fail if the argument is not a string or a object
Test if the selector passed to remove() is a String or Object else return 0
Add missing var self = this; to interceptDownload
Remove unnecessary var self = this; declaration
Update google cloud integration example
Allow `headers` to be passed as an option to FilesCollection#load
 - No more CoffeeScript
 - Compatibility with `meteor@1.5.2.2`
 - NPM and Atmosphere dependencies update
 - No more coffee and CoffeeScript
 - __Deprecated__: globally available `Meteor.Files`
 - Implemented: `disableUpload` - Disable file upload, useful for
server only solutions, see updated [*Constructor*
docs](https://github.com/VeliovGroup/Meteor-Files/wiki/Constructor)
 - Implemented: `disableDownload` - Disable file download (serving),
useful for file management only solutions, see updated [*Constructor*
docs](https://github.com/VeliovGroup/Meteor-Files/wiki/Constructor)
 - Minor fix in [Google Cloud Storage
Integration](https://github.com/VeliovGroup/Meteor-Files/wiki/Google-Clo
ud-Storage-Integration), big thanks to @amos-whitewolf , see #498
 - Implemented: Custom headers in [`.load()` method
(*updated*)](https://github.com/VeliovGroup/Meteor-Files/wiki/Load),
thanks to @zwjcarter , see #501
 - Move events interface to [`eventemitter3`
package](https://github.com/primus/eventemitter3)
 - Solve #500 removing 25ms delay before setting `auth-token-cookie`
for `protected` downloads, thanks to @vbelolapotkov for pointing this
out. Not sure if this will help for initial issue which stated `First
download attempt`, as Meteor's login is async and happens only after
DDP connection is established.
 - Fix `this.user` in `onBeforeRemove` hook
 - Deprecate (*temporarily*) `throttle` option, not sure if it was
working from the beginning
@dr-dimitru dr-dimitru merged commit b5e1a6b into master Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/veliovgroup/Meteor-Files/pull/507

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy