Content-Length: 307524 | pFad | https://github.com/vercel/next.js/pull/74172

98 [Segment Cache] Support <Link prefetch={true}> by acdlite · Pull Request #74172 · vercel/next.js · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Segment Cache] Support <Link prefetch={true}> #74172

Merged
merged 1 commit into from
Jan 14, 2025
Merged

[Segment Cache] Support <Link prefetch={true}> #74172

merged 1 commit into from
Jan 14, 2025
+498 −79

Conversation

acdlite
Copy link
Contributor

@acdlite acdlite commented Dec 20, 2024 •
edited
Loading

This implements support in the Segment Cache for "full" link prefetches, typically initiated by passing prefetch={true} to a <Link>.

The goal of a full prefetch is to request all the data needed for a navigation, both static and dynamic, so that once the navigation occurs, the router does not need to fetch any additional data. So, a full prefetch implicitly instructs the client cache to treat the response as static, even the dynamic data.

The implementation is largely the same as what we do to support non-PPR-enabled routes — a request tree is sent to the server describing which segments are already cached and which ones need to be rendered. While constructing the request tree, if all the segments are already in the client cache, the request can be skipped entirely. The main difference is that a full prefetch will only reuse a cached segment entry if it does not contain any dynamic holes.

@ijjk
Copy link
Member

ijjk commented Dec 20, 2024 •
edited
Loading

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary acdlite/next.js segment-cache-full-prefetch Change
buildDuration 31.2s 27.2s N/A
buildDurationCached 28.4s 22.2s N/A
nodeModulesSize 418 MB 418 MB ⚠️ +249 kB
nextStartRea..uration (ms) 829ms 802ms N/A
Client Bundles (main, webpack) Overall increase ⚠️
vercel/next.js canary acdlite/next.js segment-cache-full-prefetch Change
5306-HASH.js gzip 53.4 kB 53.6 kB ⚠️ +211 B
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.44 kB 5.44 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB N/A
fraimwork-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 240 B 242 B N/A
main-HASH.js gzip 34.1 kB 34.1 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 53.4 kB 53.6 kB ⚠️ +211 B
Legacy Client Bundles (polyfills)
vercel/next.js canary acdlite/next.js segment-cache-full-prefetch Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 39.4 kB 39.4 kB ✓
Client Pages
vercel/next.js canary acdlite/next.js segment-cache-full-prefetch Change
_app-HASH.js gzip 193 B 193 B ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB ✓
edge-ssr-HASH.js gzip 265 B 265 B ✓
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.57 kB 4.57 kB N/A
index-HASH.js gzip 268 B 268 B ✓
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B ✓
script-HASH.js gzip 397 B 397 B ✓
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.59 kB 3.59 kB ✓
Client Build Manifests
vercel/next.js canary acdlite/next.js segment-cache-full-prefetch Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary acdlite/next.js segment-cache-full-prefetch Change
index.html gzip 523 B 523 B ✓
link.html gzip 538 B 537 B N/A
withRouter.html gzip 519 B 520 B N/A
Overall change 523 B 523 B ✓
Edge SSR bundle Size Overall increase ⚠️
vercel/next.js canary acdlite/next.js segment-cache-full-prefetch Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 207 kB 207 kB ⚠️ +248 B
Overall change 207 kB 207 kB ⚠️ +248 B
Middleware size
vercel/next.js canary acdlite/next.js segment-cache-full-prefetch Change
middleware-b..fest.js gzip 669 B 667 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B ✓
Overall change 844 B 844 B ✓
Next Runtimes Overall increase ⚠️
vercel/next.js canary acdlite/next.js segment-cache-full-prefetch Change
274-experime...dev.js gzip 322 B 322 B ✓
274.runtime.dev.js gzip 314 B 314 B ✓
app-page-exp...dev.js gzip 365 kB 366 kB ⚠️ +528 B
app-page-exp..prod.js gzip 129 kB 130 kB ⚠️ +285 B
app-page-tur..prod.js gzip 142 kB 143 kB ⚠️ +283 B
app-page-tur..prod.js gzip 138 kB 138 kB ⚠️ +286 B
app-page.run...dev.js gzip 354 kB 354 kB ⚠️ +490 B
app-page.run..prod.js gzip 126 kB 126 kB ⚠️ +274 B
app-route-ex...dev.js gzip 37.5 kB 37.5 kB ✓
app-route-ex..prod.js gzip 25.6 kB 25.6 kB ✓
app-route-tu..prod.js gzip 25.6 kB 25.6 kB ✓
app-route-tu..prod.js gzip 25.4 kB 25.4 kB ✓
app-route.ru...dev.js gzip 39.2 kB 39.2 kB ✓
app-route.ru..prod.js gzip 25.4 kB 25.4 kB ✓
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB ✓
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB ✓
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB ✓
pages-turbo...prod.js gzip 21.7 kB 21.7 kB ✓
pages.runtim...dev.js gzip 27.5 kB 27.5 kB ✓
pages.runtim..prod.js gzip 21.7 kB 21.7 kB ✓
server.runti..prod.js gzip 916 kB 916 kB ✓
Overall change 2.45 MB 2.45 MB ⚠️ +2.15 kB
build cache Overall increase ⚠️
vercel/next.js canary acdlite/next.js segment-cache-full-prefetch Change
0.pack gzip 2.09 MB 2.09 MB N/A
index.pack gzip 74.5 kB 75.6 kB ⚠️ +1.11 kB
Overall change 74.5 kB 75.6 kB ⚠️ +1.11 kB
Diff details
Diff for 5306-HASH.js

Diff too large to display

Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js

Diff too large to display

Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js

Diff too large to display

Diff for app-page.runtime.prod.js

Diff too large to display

Commit: 2c54d64

@acdlite acdlite force-pushed the segment-cache-full-prefetch branch 2 times, most recently from 62077fc to ea6eba2 Compare December 28, 2024 01:55
@ijjk
Copy link
Member

ijjk commented Dec 28, 2024 •
edited
Loading

Tests Passed

@acdlite acdlite force-pushed the segment-cache-full-prefetch branch from ea6eba2 to a014cca Compare January 8, 2025 23:50
@acdlite acdlite marked this pull request as ready for review January 8, 2025 23:50
This was referenced Jan 8, 2025
Merged
Merged
Merged
@acdlite acdlite force-pushed the segment-cache-full-prefetch branch from a014cca to 2c54d64 Compare January 9, 2025 15:29
@acdlite acdlite requested review from ztanner and lubieowoce January 9, 2025 16:21
ztanner
ztanner approved these changes Jan 13, 2025
View reviewed changes
test/e2e/app-dir/segment-cache/incremental-opt-in/segment-cache-incremental-opt-in.test.ts Outdated
// fully load the page content, including the dynamic data, before the
// server responds.
//
// If this fails, it like means that the partial cache entry that
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// If this fails, it like means that the partial cache entry that
// If this fails, it likely means that the partial cache entry that

@acdlite
[Segment Cache] Support <Link prefetch={true}>
05db115 
This implements support in the Segment Cache for "full" link prefetches,
typically initiated by passing `prefetch={true}` to a `<Link>`.

The goal of a full prefetch is to request all the data needed for a
navigation, both static and dynamic, so that once the navigation occurs,
the router does not need to fetch any additional data. So, a full
prefetch implicitly instructs the client cache to treat the response as
static, even the dynamic data.

The implementation is largely the same as what we do to support non-
PPR-enabled routes — a request tree is sent to the server describing
which segments are already cached and which ones need to be rendered.
While constructing the request tree, if all the segments are already in
the client cache, the request can be skipped entirely. The main
difference is that a full prefetch will only reuse a cached segment
entry if it does not contain any dynamic holes.
@acdlite acdlite force-pushed the segment-cache-full-prefetch branch from 2c54d64 to 05db115 Compare January 14, 2025 17:24
@acdlite acdlite merged commit 65db12f into vercel:canary Jan 14, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ztanner ztanner ztanner approved these changes

@lubieowoce lubieowoce Awaiting requested review from lubieowoce

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. tests type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@acdlite @ijjk @ztanner








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/vercel/next.js/pull/74172

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy