Content-Length: 332708 | pFad | https://github.com/videojs/video.js/issues/5671

08 Move the "-" in remaining-time-display.js so it is not announced by screen readers. Fixes #5168 by smbea · Pull Request #5671 · videojs/video.js · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the "-" in remaining-time-display.js so it is not announced by screen readers. Fixes #5168 #5671

Merged
merged 4 commits into from
Jan 4, 2019
Merged

Move the "-" in remaining-time-display.js so it is not announced by screen readers. Fixes #5168 #5671

merged 4 commits into from
Jan 4, 2019

Conversation

smbea
Copy link
Contributor

@smbea smbea commented Dec 11, 2018 •
edited by gkatsev
Loading

Description

Fixes issue #5168 @gkatsev
Remaining time is now a positive value by it's own and the negative sign is added decoratively.

Specific Changes proposed

  • Removed negative sign in when returning the remaining time
  • Added the negative ('-') sign to the number's container and make it 'aria-hidden' so screen readers can't read it

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@welcome
Copy link

welcome bot commented Dec 11, 2018

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@gkatsev gkatsev added minor This PR can be added to a minor release. It should not be added to a patch release. patch This PR can be added to a patch release. and removed minor This PR can be added to a minor release. It should not be added to a patch release. labels Dec 11, 2018
@OwenEdwards OwenEdwards changed the title fixed issue 5168 Move the "-" in remaining-time-display.js so it is not announced by screen readers. Fixes #5168 Dec 11, 2018
@gkatsev gkatsev added the a11y This item might affect the accessibility of the player label Dec 18, 2018
gkatsev
gkatsev approved these changes Dec 18, 2018
View reviewed changes
Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.
@OwenEdwards can you take a look?

@gkatsev gkatsev requested a review from OwenEdwards December 18, 2018 19:54
@gkatsev gkatsev added the needs: LGTM Needs one or more additional approvals label Dec 19, 2018
OwenEdwards
OwenEdwards requested changes Dec 21, 2018
View reviewed changes
Copy link
Member

@OwenEdwards OwenEdwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gkatsev I think this needs this one change, just for consistency/clarity. Otherwise, it LGTM.

src/js/control-bar/time-controls/remaining-time-display.js Show resolved Hide resolved
@gkatsev gkatsev added this to the 7.4.x milestone Jan 4, 2019
@OwenEdwards OwenEdwards removed the needs: LGTM Needs one or more additional approvals label Jan 4, 2019
@gkatsev gkatsev merged commit 9a8376e into videojs:master Jan 4, 2019
@welcome
Copy link

welcome bot commented Jan 4, 2019

Congrats on merging your first pull request! 🎉🎉🎉

gkatsev pushed a commit that referenced this pull request Jan 8, 2019
@smbea @gkatsev
fix(remaining-time-display): make the '-' be visual and not readable …
05513f8 
…by screen readers (#5671)

Fixes #5168
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkatsev gkatsev gkatsev approved these changes

@OwenEdwards OwenEdwards OwenEdwards approved these changes

Assignees
No one assigned
Labels
a11y This item might affect the accessibility of the player patch This PR can be added to a patch release.
Projects
None yet
Milestone
7.4.x
Development

Successfully merging this pull request may close these issues.
3 participants
@smbea @gkatsev @OwenEdwards








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/videojs/video.js/issues/5671

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy