feat: expose EnvironmentOptions
type
#18080
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As an environment author I might like to implement a factory function like:
(example)
The problem here would be that no type checking nor autocompletion would be applied to the return type, so I might need to manually type
dev
,build
etc... if I want to have type checking/autocompletion there (for example in my example notice how I had to set thecreateEnvironment
arguments and return types).There are also fields on the top environment object that I'd like to have types for too, such as
consumer
.So I think it would be pretty convenient to expose the
EnvironmentOptions
type to vite users.I am not sure if this was simply missed or exposing this type was considered but not done on purpose for some reason, I figured I could just open this PR and see what you guys say 🙂