Clean up dependencies #309
Conversation
|
|
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
package.json
Outdated
| "v8-compile-cache": "^1.1.2", | ||
| "webpack-addons": "^1.1.5", | ||
| "yargs": "9.0.1", | ||
| "yargs": "^9.0.1", |
There was a problem hiding this comment.
@shellscape which version was corrupted?
There was a problem hiding this comment.
I believe it was 8.x, but I can't recall for sure.
| "mkdirp": "^0.5.1", | ||
| "p-each-series": "^1.0.0", | ||
| "p-lazy": "^1.0.0", | ||
| "prettier": "^1.5.3", | ||
| "recast": "^0.14.4", |
There was a problem hiding this comment.
We don't use recast inside the code? :O
There was a problem hiding this comment.
No, a recast object is passed around but it looks like it's created by jscodeshift (which has its own dependency on a different version of recast)
|
@ematipico prettier is used in lib code, I think to format webpack configs that it outputs? |
|
@billyjanitsch Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ematipico Please review the new changes. |
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-approved
PR: reviewed-changes-requested
labels
|
Done! I also refreshed the package-lock.json, but I can revert that if you'd prefer. |
What kind of change does this PR introduce?
A general clean-up of dependencies.
Did you add tests for your changes? If relevant, did you update the documentation?
No, but I'm happy to if you'd like.
Summary
npm i global pkginstead ofnpm i --global pkg)Let me know if you'd like me to back out or further discuss any of the changes individually.
Does this PR introduce a breaking change?
No. These are intended not to have any behavioral effect on the CLI.
Other information