Content-Length: 249651 | pFad | https://github.com/xtdb/xtdb/pull/3293

A9 Python: Add support for 3.10 by Akeboshiwind · Pull Request #3293 · xtdb/xtdb · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: Add support for 3.10 #3293

Merged
merged 5 commits into from
Apr 10, 2024
Merged

Python: Add support for 3.10 #3293

merged 5 commits into from
Apr 10, 2024

Conversation

Akeboshiwind
Copy link
Contributor

@Akeboshiwind Akeboshiwind commented Apr 9, 2024 •
edited
Loading

Why? It's the version that google colab runs 🤷

Not tested anything other than:

from xtdb_juxt import Xtdb
from xtdb_juxt.tx import PutDocs
from xtdb_juxt.query import *

client = Xtdb(f"http://localhost:3000")

txs = [PutDocs("docs", {"xt$id": 1, "foo": "hello"}, {"xt$id": 2, "bar": "test"})]
client.submit_tx(txs)
client.query(From("docs", projectAllCols=True))

@Akeboshiwind
feat(python): reduce minimum supported version to 3.10
f9c1346 
This is the version that google colab runs
@Akeboshiwind
fix(python): type error
765c511 
This syntax was only supported in 3.11:
https://peps.python.org/pep-0646/
@Akeboshiwind
fix(python): type error
c3bc55d
@Akeboshiwind
fix(python): manually replace Z in system time
154a8f5 
Better parsing in datetime.fromisoformat was only added in 3.11:
python/cpython#80010

Another option is to add python-dateutil as a dependency, not tested
that though
@Akeboshiwind
fix(python): use python-dateutil instead of string hack
174c657
@Akeboshiwind Akeboshiwind marked this pull request as ready for review April 10, 2024 10:11
@Akeboshiwind Akeboshiwind changed the title [WIP] Python: Add support for 3.10 Python: Add support for 3.10 Apr 10, 2024
@Akeboshiwind Akeboshiwind merged commit bc361f1 into xtdb:main Apr 10, 2024
1 check passed
@Akeboshiwind Akeboshiwind deleted the py_support-3.10 branch April 10, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Akeboshiwind








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/xtdb/xtdb/pull/3293

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy