Content-Length: 239089 | pFad | https://github.com/zyrouge/node-genius-lyrics/issues/8

45 Please add support for optional genius api host address · Issue #8 · zyrouge/node-genius-lyrics · GitHub

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please add support for optional genius api host address #8

Closed

vitaliikravets opened this issue Jan 15, 2021 · 4 comments

Labels

vitaliikravets commented Jan 15, 2021

I would like to use this library from browser.
In order to fight the CORS , improve performance and lower the load on actual API, I am setting up a CDN that will have the same domain name as my website but will redirect all calls to genius.com.

zyrouge added the enhancement label

Owner

zyrouge commented Jan 16, 2021

Soon™

Owner

zyrouge commented Jan 18, 2021

🎉Added in v4.2.0

zyrouge closed this as completed

Author

vitaliikravets commented Jan 18, 2021

Wow @zyrouge that was a very prompt response, thanks!
Is genius website URL (www.genius.com) also configurable? To be able to fetch the lyrics from the browser?

Owner

zyrouge commented Jan 18, 2021

Wow @zyrouge that was a very prompt response, thanks!
Is genius website URL (www.genius.com) also configurable? To be able to fetch the lyrics from the browser?

Yeah options.origen.url

This was referenced Mar 9, 2021

Bump genius-lyrics from 3.0.0 to 4.2.5 orangixx/cryptic-old#1

Closed

Bump genius-lyrics from 3.0.0 to 4.2.5 redteadeveloper/Maestro#53

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment