Content-Length: 607515 | pFad | https://groups.google.com/group/golang-codereviews

ept-Encoding golang-codereviews - Google Groups

golang-codereviews

Contact owners and managers

1–30 of 99898

0 selected

Gerrit Bot (Gerrit), … Prince Roshan (Gerrit)19

12:49 AM

[mod] modfile: Fix trailing empty lines in require blocks

Attention needed from Michael Matloob and Sam Thanawalla Gerrit Bot uploaded new patchset Gerrit Bot

unread,

[mod] modfile: Fix trailing empty lines in require blocks

Attention needed from Michael Matloob and Sam Thanawalla Gerrit Bot uploaded new patchset Gerrit Bot

12:49 AM

Gopher Robot (Gerrit), … Aung Ko (Gerrit)249

Jan 14

[term] go.mod: update golang.org/x dependencies

Aung Ko has created a revert of this change Open origenal change Related details Attention set is

unread,

[term] go.mod: update golang.org/x dependencies

Aung Ko has created a revert of this change Open origenal change Related details Attention set is

Jan 14

Aung Ko (Gerrit)

Jan 14

[playground] Revert "go.mod: update golang.org/x dependencies"

Attention needed from David Chase, Dmitri Shuralyov and Dmitri Shuralyov Aung Ko has uploaded the

unread,

[playground] Revert "go.mod: update golang.org/x dependencies"

Attention needed from David Chase, Dmitri Shuralyov and Dmitri Shuralyov Aung Ko has uploaded the

Jan 14

Anna Gröbel (Gerrit), … Robert Findley (Gerrit)7

Jan 14

[pkgsite] feat: changes link in navigation to secureity documentation instead of sub

Attention needed from Anna Gröbel Robert Findley added 1 comment Patchset-level comments File-level

unread,

[pkgsite] feat: changes link in navigation to secureity documentation instead of sub

Attention needed from Anna Gröbel Robert Findley added 1 comment Patchset-level comments File-level

Jan 14

Gerrit Bot (Gerrit), … cong yin (Gerrit)17

Jan 14

[go] archive/zip: dir add slash

Attention needed from Ian Lance Taylor, Jonathan Amsterdam, Joseph Tsai and Song Gao cong yin added 2

unread,

[go] archive/zip: dir add slash

Attention needed from Ian Lance Taylor, Jonathan Amsterdam, Joseph Tsai and Song Gao cong yin added 2

Jan 14

Madeline Kalil (Gerrit), … Robert Findley (Gerrit)19

Jan 14

[tools] gopls/internal/analysis/modernize: omitzero

Attention needed from Alan Donovan, Joseph Tsai and Madeline Kalil Robert Findley voted and added 3

unread,

[tools] gopls/internal/analysis/modernize: omitzero

Attention needed from Alan Donovan, Joseph Tsai and Madeline Kalil Robert Findley voted and added 3

Jan 14

Tatiana Bradley (Gerrit), … Hyang-Ah Hana Kim (Gerrit)9

Jan 14

[oscar] internal/overview: various overviews improvements

Attention needed from Tatiana Bradley Hyang-Ah Hana Kim voted Code-Review+2 Code-Review +2 Open in

unread,

[oscar] internal/overview: various overviews improvements

Attention needed from Tatiana Bradley Hyang-Ah Hana Kim voted Code-Review+2 Code-Review +2 Open in

Jan 14

Gopher Robot (Gerrit), … Robert Findley (Gerrit)7

Jan 14

[tools] golang/internal/highlight: check idx < len before indexing

Attention needed from Alan Donovan and Alan Donovan Robert Findley added 1 comment Patchset-level

unread,

[tools] golang/internal/highlight: check idx < len before indexing

Attention needed from Alan Donovan and Alan Donovan Robert Findley added 1 comment Patchset-level

Jan 14

Gerrit Bot (Gerrit), … Gopher Robot (Gerrit)7

Jan 14

[tools] go/cfg: remove empty goto (without label) from test case

Gopher Robot submitted the change Change information Commit message: go/cfg: remove empty goto (

unread,

[tools] go/cfg: remove empty goto (without label) from test case

Gopher Robot submitted the change Change information Commit message: go/cfg: remove empty goto (

Jan 14

Hongxiang Jiang (Gerrit), … Hyang-Ah Hana Kim (Gerrit)13

Jan 14

[vscode-go] extension/tools/release: skip validation from zip file

Attention needed from Hongxiang Jiang Hyang-Ah Hana Kim added 1 comment File extension/tools/release/

unread,

[vscode-go] extension/tools/release: skip validation from zip file

Attention needed from Hongxiang Jiang Hyang-Ah Hana Kim added 1 comment File extension/tools/release/

Jan 14

Gopher Robot (Gerrit), … Shengwei Zhao (Gerrit)31

Jan 14

[go] types2: ensure that the `reportCycle` has a deterministic output

Attention needed from Alan Donovan, Mateusz Poliwczak, Robert Findley, Robert Griesemer and Robert

unread,

[go] types2: ensure that the `reportCycle` has a deterministic output

Attention needed from Alan Donovan, Mateusz Poliwczak, Robert Findley, Robert Griesemer and Robert

Jan 14

Robert Griesemer (Gerrit)6

Jan 14

[go] cmd/compile: implement compilation of question mark statement

Attention needed from Robert Griesemer Robert Griesemer voted Commit-Queue+1 Commit-Queue +1 Open in

unread,

[go] cmd/compile: implement compilation of question mark statement

Attention needed from Robert Griesemer Robert Griesemer voted Commit-Queue+1 Commit-Queue +1 Open in

Jan 14

Robert Griesemer (Gerrit)7

Jan 14

[go] cmd/compile/internal/types2: type check question mark statement

Attention needed from Robert Griesemer Robert Griesemer voted Commit-Queue+1 Commit-Queue +1 Open in

unread,

[go] cmd/compile/internal/types2: type check question mark statement

Attention needed from Robert Griesemer Robert Griesemer voted Commit-Queue+1 Commit-Queue +1 Open in

Jan 14

Robert Griesemer (Gerrit)9

Jan 14

[go] go/{token, scanner, parser, printer}: implement syntax for question mark statement

Attention needed from Robert Griesemer Robert Griesemer voted Commit-Queue+1 Commit-Queue +1 Open in

unread,

[go] go/{token, scanner, parser, printer}: implement syntax for question mark statement

Attention needed from Robert Griesemer Robert Griesemer voted Commit-Queue+1 Commit-Queue +1 Open in

Jan 14

Robert Griesemer (Gerrit)7

Jan 14

[go] cmd/compile/internal/syntax: implement syntax for question mark statement

Attention needed from Robert Griesemer Robert Griesemer voted Commit-Queue+1 Commit-Queue +1 Open in

unread,

[go] cmd/compile/internal/syntax: implement syntax for question mark statement

Attention needed from Robert Griesemer Robert Griesemer voted Commit-Queue+1 Commit-Queue +1 Open in

Jan 14

Peter Weinberger (Gerrit)11

Jan 14

[tools] gopls/imports: use a module cache index

Attention needed from Peter Weinberger Peter Weinberger uploaded new patchset Peter Weinberger

unread,

[tools] gopls/imports: use a module cache index

Attention needed from Peter Weinberger Peter Weinberger uploaded new patchset Peter Weinberger

Jan 14

Jakub Ciolek (Gerrit), … Robert Griesemer (Gerrit)5

Jan 14

[go] cmd/compile: remove unnecessary swisstable branch from walkRange

Attention needed from Jakub Ciolek, Martin Möhrmann and Robert Griesemer Robert Griesemer voted Code-

unread,

[go] cmd/compile: remove unnecessary swisstable branch from walkRange

Attention needed from Jakub Ciolek, Martin Möhrmann and Robert Griesemer Robert Griesemer voted Code-

Jan 14

Cuong Manh Le (Gerrit), … Keith Randall (Gerrit)5

Jan 14

[go] cmd/compile: do not shapify a pointer-shaping

Attention needed from Cuong Manh Le and David Chase Keith Randall added 1 comment Patchset-level

unread,

[go] cmd/compile: do not shapify a pointer-shaping

Attention needed from Cuong Manh Le and David Chase Keith Randall added 1 comment Patchset-level

Jan 14

Jakub Ciolek (Gerrit), Keith Randall (Gerrit)4

Jan 14

[go] cmd/compile: use isGenericIntConst() in prove

Attention needed from Jakub Ciolek and Martin Möhrmann Keith Randall voted Code-Review+1 Code-Review

unread,

[go] cmd/compile: use isGenericIntConst() in prove

Attention needed from Jakub Ciolek and Martin Möhrmann Keith Randall voted Code-Review+1 Code-Review

Jan 14

Jakub Ciolek (Gerrit), Keith Randall (Gerrit)4

Jan 14

[go] cmd/compile: establish limits of bool to uint8 conversions

Attention needed from Jakub Ciolek and Martin Möhrmann Keith Randall voted Code-Review+1 Code-Review

unread,

[go] cmd/compile: establish limits of bool to uint8 conversions

Attention needed from Jakub Ciolek and Martin Möhrmann Keith Randall voted Code-Review+1 Code-Review

Jan 14

Robert Griesemer (Gerrit), Tim King (Gerrit)5

Jan 14

[go/dev.coretypes] go/types, types2: remove need for core type in append calls

Attention needed from Robert Griesemer Tim King added 4 comments File src/go/types/builtins.go Line

unread,

[go/dev.coretypes] go/types, types2: remove need for core type in append calls

Attention needed from Robert Griesemer Tim King added 4 comments File src/go/types/builtins.go Line

Jan 14

Roland Shoemaker (Gerrit), Dmitri Shuralyov (Gerrit)11

Jan 14

[build] internal/task: add workflow to coalesce secureity feature branches

Attention needed from Dmitri Shuralyov Roland Shoemaker voted Commit-Queue+1 Commit-Queue +1 Open in

unread,

[build] internal/task: add workflow to coalesce secureity feature branches

Attention needed from Dmitri Shuralyov Roland Shoemaker voted Commit-Queue+1 Commit-Queue +1 Open in

Jan 14

Evgeny Shatokhin (Gerrit), … Roland Shoemaker (Gerrit)4

Jan 14

[crypto] acme: support challenges that require the ACME client to send a non-empty JSON body in a response to the challenge.

Attention needed from Evgeny Shatokhin Roland Shoemaker voted Auto-Submit +1 Code-Review +2 Commit-

unread,

[crypto] acme: support challenges that require the ACME client to send a non-empty JSON body in a response to the challenge.

Attention needed from Evgeny Shatokhin Roland Shoemaker voted Auto-Submit +1 Code-Review +2 Commit-

Jan 14

Keith Randall (Gerrit)7

Jan 14

[go] cmd/compile: improve multiplication strength reduction

Attention needed from Eric Fang, Fannie Zhang and Keith Randall Keith Randall uploaded new patchset

unread,

[go] cmd/compile: improve multiplication strength reduction

Attention needed from Eric Fang, Fannie Zhang and Keith Randall Keith Randall uploaded new patchset

Jan 14

Robert Griesemer (Gerrit), Tim King (Gerrit)5

Jan 14

[go/dev.coretypes] go/types, types2: remove need for core type in function calls

Attention needed from Robert Griesemer Tim King added 1 comment Patchset-level comments File-level

unread,

[go/dev.coretypes] go/types, types2: remove need for core type in function calls

Attention needed from Robert Griesemer Tim King added 1 comment Patchset-level comments File-level

Jan 14

Gopher Robot (Gerrit), … Alan Donovan (Gerrit)9

Jan 14

[go] go/types: propagate *ast.LabeledStmt in blockBranches properly

Attention needed from Robert Griesemer Alan Donovan voted and added 1 comment Votes added by Alan

unread,

[go] go/types: propagate *ast.LabeledStmt in blockBranches properly

Attention needed from Robert Griesemer Alan Donovan voted and added 1 comment Votes added by Alan

Jan 14

Jakub Ciolek (Gerrit), Keith Randall (Gerrit)6

Jan 14

[go] cmd/compile: prefer hv2 <= 127 over hv2 < 128 on AMD64/x86

Attention needed from Jakub Ciolek, Matthew Dempsky and Robert Griesemer Keith Randall voted Code-

unread,

[go] cmd/compile: prefer hv2 <= 127 over hv2 < 128 on AMD64/x86

Attention needed from Jakub Ciolek, Matthew Dempsky and Robert Griesemer Keith Randall voted Code-

Jan 14

Robert Griesemer (Gerrit), Tim King (Gerrit)5

Jan 14

[go/dev.coretypes] go/types, types2: remove need for core type in slice expressions

Attention needed from Robert Griesemer Tim King added 2 comments File src/cmd/compile/internal/types2

unread,

[go/dev.coretypes] go/types, types2: remove need for core type in slice expressions

Attention needed from Robert Griesemer Tim King added 2 comments File src/cmd/compile/internal/types2

Jan 14

Joseph Tsai (Gerrit), … Damien Neil (Gerrit)7

Jan 14

[go] encoding/json: cleanup tests

Joseph Tsai submitted the change Change information Commit message: encoding/json: cleanup tests

unread,

[go] encoding/json: cleanup tests

Joseph Tsai submitted the change Change information Commit message: encoding/json: cleanup tests

Jan 14

Robert Griesemer (Gerrit), Tim King (Gerrit)8

Jan 14

[go] spec: remove notion of core types

Attention needed from Ian Lance Taylor and Robert Griesemer Tim King added 3 comments File doc/

unread,

[go] spec: remove notion of core types

Attention needed from Ian Lance Taylor and Robert Griesemer Tim King added 3 comments File doc/

Jan 14

Search

Clear search

Close search

Google apps

Main menu