[wmf.11 - regression] Custom tags not working with UploadWizard
Open, Unbreak Now!PublicPRODUCTION ERROR
Actions

Assigned To

None

Authored By

	Sannita
	Fri, Jan 10, 3:31 PM

Description

Steps to replicate the issue (include links if applicable):

I upload media with UploadWizard
I choose {{PD-US-no notice advertisement}} or {{PD-US-record-expired}} or {{PD-textlogo}} as public domain tags in the custom license field for the media I'm uploading
UploadWizard does not recognise the tags and doesn't let me go further

What happens?:
UploadWizard does not recognise the tags in the custom license field and doesn't let me go further.

What should have happened instead?:
UploadWizard should recognise such tags and let me go on with the upload.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
Reformulated from this discussion.

Details

	Subject	Repo	Branch	Lines +/-
	Fix exceptions preventing user from continuing past license deeds	mediawiki/extensions/UploadWizard	master	+39 -46

Customize query in gerrit

Related Objects

Mentioned In: T383529: Unable to move to next step for any work created by someone else with UploadWizard
T383508: UploadWizard only showing first of many files at Describe step when files contain Exif Description
Mentioned Here: rEUWI9fa34fe9b5eb: Refactor error handling
T370106: Add option to cover the usecase of users uploading on behalf of someone else
T381286: [S] Place user input's error messages closer to their relevant field

Event Timeline

Sannita created this task.Fri, Jan 10, 3:31 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFri, Jan 10, 3:32 PM

Sannita added projects: Structured-Data-Backlog, UploadWizard.Fri, Jan 10, 3:33 PM

Sannita added a subscriber: Abzeronow.

see also: https://commons.wikimedia.org/wiki/Commons:Upload_Wizard_feedback#Upload_Wizard_broken

This is breaking the workflow of tons of people and should get a higher priority or commits should be reverted as I don't see this fixed over the weekend.

Bumping priority per above. Based on timing, it's probably something from https://www.mediawiki.org/wiki/MediaWiki_1.44/wmf.11#UploadWizard. Maybe something from T381286 or T370106, maybe something else?

Traceback in the red popup from when I reproduced this:

Uncaught TypeError: status.getErrors is not a function
from https://commons.wikimedia.org/w/load.php?lang=en&modules=ext.uploadWizard%7Cext.uploadWizard.page&skin=vector&version=15ev5 at line 130:398 TypeError: status.getErrors is not a function at uw.ValidationMessageElement.postValidate (https://commons.wikimedia.org/w/load.php?lang=en&modules=ext.uploadWizard%7Cext.uploadWizard.page&skin=vector&version=15ev5:130:398) at https://commons.wikimedia.org/w/load.php?lang=en&modules=ext.uploadWizard%7Cext.uploadWizard.page&skin=vector&version=15ev5:130:284 at fire (https://commons.wikimedia.org/w/load.php?lang=en&modules=jquery%2Coojs-ui-core%7Cjquery.ui%7Cmediawiki.feedback%2CmessagePoster%7Cmediawiki.widgets.styles&skin=vector&version=drcfd:42:705) at Object.fireWith [as rejectWith] (https://commons.wikimedia.org/w/load.php?lang=en&modules=jquery%2Coojs-ui-core%7Cjquery.ui%7Cmediawiki.feedback%2CmessagePoster%7Cmediawiki.widgets.styles&skin=vector&version=drcfd:43:903) at process (https://commons.wikimedia.org/w/load.php?lang=en&modules=jquery%2Coojs-ui-core%7Cjquery.ui%7Cmediawiki.feedback%2CmessagePoster%7Cmediawiki.widgets.styles&skin=vector&version=drcfd:46:492)

And from my Dev Console:

jQuery.Deferred exception: this.getUsedTemplates is not a function TypeError: this.getUsedTemplates is not a function
    at input.validate (https://commons.wikimedia.org/w/load.php?lang=en&modules=ext.uploadWizard%7Cext.uploadWizard.page&skin=vector&version=15ev5:146:887)
    at https://commons.wikimedia.org/w/load.php?lang=en&modules=ext.uploadWizard%7Cext.uploadWizard.page&skin=vector&version=15ev5:130:242
    at mightThrow (https://commons.wikimedia.org/w/load.php?lang=en&modules=jquery%2Coojs-ui-core%7Cjquery.ui%7Cmediawiki.feedback%2CmessagePoster%7Cmediawiki.widgets.styles&skin=vector&version=drcfd:45:648)
    at process (https://commons.wikimedia.org/w/load.php?lang=en&modules=jquery%2Coojs-ui-core%7Cjquery.ui%7Cmediawiki.feedback%2CmessagePoster%7Cmediawiki.widgets.styles&skin=vector&version=drcfd:46:309) undefined

uw.ValidationMessageElement.js:64 Uncaught TypeError: status.getErrors is not a function
    at uw.ValidationMessageElement.postValidate (uw.ValidationMessageElement.js:64:26)
    at uw.ValidationMessageElement.js:56:32
    at fire (jquery.js:3223:31)
    at Object.fireWith [as rejectWith] (jquery.js:3353:7)
    at process (jquery.js:3577:22)

jquery.js:3783 jQuery.Deferred exception: this.getUsedTemplates is not a function TypeError: this.getUsedTemplates is not a function
    at input.validate (https://commons.wikimedia.org/w/load.php?lang=en&modules=ext.uploadWizard%7Cext.uploadWizard.page&skin=vector&version=15ev5:146:887)
    at https://commons.wikimedia.org/w/load.php?lang=en&modules=ext.uploadWizard%7Cext.uploadWizard.page&skin=vector&version=15ev5:130:242
    at mightThrow (https://commons.wikimedia.org/w/load.php?lang=en&modules=jquery%2Coojs-ui-core%7Cjquery.ui%7Cmediawiki.feedback%2CmessagePoster%7Cmediawiki.widgets.styles&skin=vector&version=drcfd:45:648)
    at process (https://commons.wikimedia.org/w/load.php?lang=en&modules=jquery%2Coojs-ui-core%7Cjquery.ui%7Cmediawiki.feedback%2CmessagePoster%7Cmediawiki.widgets.styles&skin=vector&version=drcfd:46:309) undefined

jquery.js:3783 jQuery.Deferred exception: status.getErrors is not a function TypeError: status.getErrors is not a function
    at https://commons.wikimedia.org/w/load.php?lang=en&modules=ext.uploadWizard%7Cext.uploadWizard.page&skin=vector&version=15ev5:132:229
    at Array.forEach (<anonymous>)
    at uw.ValidationStatus.mergeStatus (https://commons.wikimedia.org/w/load.php?lang=en&modules=ext.uploadWizard%7Cext.uploadWizard.page&skin=vector&version=15ev5:132:203)
    at https://commons.wikimedia.org/w/load.php?lang=en&modules=ext.uploadWizard%7Cext.uploadWizard.page&skin=vector&version=15ev5:132:659
    at mightThrow (https://commons.wikimedia.org/w/load.php?lang=en&modules=jquery%2Coojs-ui-core%7Cjquery.ui%7Cmediawiki.feedback%2CmessagePoster%7Cmediawiki.widgets.styles&skin=vector&version=drcfd:45:648)
    at process (https://commons.wikimedia.org/w/load.php?lang=en&modules=jquery%2Coojs-ui-core%7Cjquery.ui%7Cmediawiki.feedback%2CmessagePoster%7Cmediawiki.widgets.styles&skin=vector&version=drcfd:46:309) undefined

Restricted Application changed the subtype of this task from "Bug Report" to "Production Error". · View Herald TranscriptFri, Jan 10, 8:18 PM

mdaniels5757 renamed this task from [wmf.11 - regression] Some public domain tags are not working with UploadWizard to [wmf.11 - regression] Custom tags not working with UploadWizard.Fri, Jan 10, 8:20 PM

mdaniels5757 added a project: Commons.

The same phenomenon has also occurred with licenses that were previously accepted, such as {{PD-Somalia}}.

I have such problems with {{PD-text}} {{PD-shape}} and {{Data license Germany-attribution-2.0}}

Reproducible with {{PD-PRC-exempt}}.
I thought it was a bug with my browser. It turns out to trouble many uploaders.

Aklapper raised the priority of this task from High to Unbreak Now!.Sat, Jan 11, 1:45 PM

MarkTraceur moved this task from Triage to Current Work on the Structured-Data-Backlog board.Sat, Jan 11, 3:04 PM

MarkTraceur edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.

MarkTraceur moved this task from Incoming to Ready for Development on the Structured-Data-Backlog (Current Work) board.

Addshore subscribed.Sat, Jan 11, 6:12 PM

GPSLeo subscribed.Sat, Jan 11, 8:41 PM

I had the problem with {{PD-USGov-Army}}. Worked around it by checking the US gov box, then later changing the licence from {{PD-USGov}} to {{PD-USGov-Army}}

Pcoombe mentioned this in T383508: UploadWizard only showing first of many files at Describe step when files contain Exif Description.Sun, Jan 12, 12:21 AM

Traceback in Chrome:

Uncaught TypeError: status.getErrors is not a function
    at uw.ValidationMessageElement.postValidate (uw.ValidationMessageElement.js:64:26)
    at uw.ValidationMessageElement.js:56:32
    at fire (jquery.js:3223:31)
    at Object.fireWith [as rejectWith] (jquery.js:3353:7)
    at process (jquery.js:3577:22)

I picked a non-custom license in order to upload. Then after the upload, I changed to the custom license: {{PD-chart}}

Jeff_G subscribed.Sun, Jan 12, 12:21 PM

I have the same problem with {{PD-VenezuelaGov}} and {{PD-textlogo}}, uploadwizard does not recognize these tags (google translator).

SDudley subscribed.Sun, Jan 12, 4:31 PM

Note: to reproduce on a local mediawiki install requires setting $wgUploadWizardConfig['customLicenseTemplate'] = 'Template:License_template_tag'; to trigger the faulty code path.

It is caused by 9fa34fe9b5eb8c297ff3125ffa758c30f8ca707b

Change #1110456 had a related patch set uploaded (by Dylsss; author: Dylsss):

[mediawiki/extensions/UploadWizard@master] Fix exceptions preventing user from continuing past license deeds

https://gerrit.wikimedia.org/r/1110456

gerritbot added a project: Patch-For-Review.Mon, Jan 13, 12:07 AM

Dylsss mentioned this in T383529: Unable to move to next step for any work created by someone else with UploadWizard.Mon, Jan 13, 12:35 AM

Jamez42 subscribed.Mon, Jan 13, 2:12 AM